Changeset 244355 in webkit
- Timestamp:
- Apr 16, 2019 1:32:49 PM (5 years ago)
- Location:
- trunk/Source
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r244353 r244355 1 2019-04-16 Timothy Hatcher <timothy@apple.com> 2 3 FrameView base background color always starts white. 4 https://bugs.webkit.org/show_bug.cgi?id=196976 5 6 Reviewed by Beth Dakin. 7 8 * page/FrameView.cpp: 9 (WebCore::FrameView::setBaseBackgroundColor): Bail early if the base background 10 color did not change. 11 1 12 2019-04-16 Devin Rousso <drousso@apple.com> 2 13 -
trunk/Source/WebCore/page/FrameView.cpp
r244182 r244355 2985 2985 void FrameView::setBaseBackgroundColor(const Color& backgroundColor) 2986 2986 { 2987 m_baseBackgroundColor = backgroundColor.isValid() ? backgroundColor : Color::white; 2987 Color newBaseBackgroundColor = backgroundColor.isValid() ? backgroundColor : Color::white; 2988 if (m_baseBackgroundColor == newBaseBackgroundColor) 2989 return; 2990 2991 m_baseBackgroundColor = newBaseBackgroundColor; 2988 2992 2989 2993 if (!isViewForDocumentInFrame()) -
trunk/Source/WebKit/ChangeLog
r244333 r244355 1 2019-04-16 Timothy Hatcher <timothy@apple.com> 2 3 FrameView base background color always starts white. 4 https://bugs.webkit.org/show_bug.cgi?id=196976 5 6 Reviewed by Beth Dakin. 7 8 * WebProcess/WebPage/WebPage.cpp: 9 (WebKit::WebPage::WebPage): Set m_backgroundColor before calling 10 WebFrame::createWithCoreMainFrame so the call to create the FrameView 11 for the empty page in transitionToCommittedForNewPage() gets 12 the correct color from WebPage. 13 1 14 2019-04-16 Ryan Haddad <ryanhaddad@apple.com> 2 15 -
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
r244291 r244355 498 498 updatePreferences(parameters.store); 499 499 500 m_backgroundColor = parameters.backgroundColor; 501 500 502 m_drawingArea = DrawingArea::create(*this, parameters); 501 503 m_drawingArea->setPaintingEnabled(false); … … 671 673 PlatformMediaSessionManager::setShouldDeactivateAudioSession(true); 672 674 #endif 673 674 setBackgroundColor(parameters.backgroundColor);675 675 } 676 676
Note: See TracChangeset
for help on using the changeset viewer.