Changeset 244489 in webkit

Timestamp:

Apr 20, 2019 12:16:22 PM (5 years ago)

Author:

rniwa@webkit.org

Message:

HashTable::removeIf always shrinks the hash table by half even if there is nothing left
​https://bugs.webkit.org/show_bug.cgi?id=196681
<rdar://problem/49917764>

Reviewed by Darin Adler.

Address Darin's comments by removing the explicit type from std::max.

• wtf/HashTable.h:

(WTF::KeyTraits>::computeBestTableSize):
(WTF::KeyTraits>::shrinkToBestSize):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/HashTable.h (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2019-04-19  Ryosuke Niwa  <rniwa@webkit.org>
+
+        HashTable::removeIf always shrinks the hash table by half even if there is nothing left
+        https://bugs.webkit.org/show_bug.cgi?id=196681
+        <rdar://problem/49917764>
+
+        Reviewed by Darin Adler.
+
+        Address Darin's comments by removing the explicit type from std::max.
+
+        * wtf/HashTable.h:
+        (WTF::KeyTraits>::computeBestTableSize):
+        (WTF::KeyTraits>::shrinkToBestSize):
+
 2019-04-18  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WTF/wtf/HashTable.h

@@ -1211 +1211 @@
 
         unsigned minimumTableSize = KeyTraits::minimumTableSize;
-        return std::max<unsigned>(bestTableSize, minimumTableSize);
+        return std::max(bestTableSize, minimumTableSize);
     }
 
@@ -1218 +1218 @@
     {
         unsigned minimumTableSize = KeyTraits::minimumTableSize;
-        rehash(std::max<unsigned>(minimumTableSize, computeBestTableSize(m_keyCount)), nullptr);
+        rehash(std::max(minimumTableSize, computeBestTableSize(m_keyCount)), nullptr);
     }