Changeset 244490 in webkit

Timestamp:

Apr 20, 2019 4:46:25 PM (5 years ago)

Author:

jer.noble@apple.com

Message:

REGRESSION(r243958): Unnecessary deactivation of AudioSession (PLT Regression)
​https://bugs.webkit.org/show_bug.cgi?id=197123
<rdar://problem/49783264>

Reviewed by Per Arne Vollan.

Only set m_becameActive if we actually activated the AudioSession before starting playback. This
avoids unnecessarily deactivating the AudioSession in processWillSuspend().

• platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::sessionWillBeginPlayback):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/audio/PlatformMediaSessionManager.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-04-20  Jer Noble  <jer.noble@apple.com>
+
+        REGRESSION(r243958): Unnecessary deactivation of AudioSession (PLT Regression)
+        https://bugs.webkit.org/show_bug.cgi?id=197123
+        <rdar://problem/49783264>
+
+        Reviewed by Per Arne Vollan.
+
+        Only set m_becameActive if we actually activated the AudioSession before starting playback. This
+        avoids unnecessarily deactivating the AudioSession in processWillSuspend().
+
+        * platform/audio/PlatformMediaSessionManager.cpp:
+        (WebCore::PlatformMediaSessionManager::sessionWillBeginPlayback):
+
 2019-04-19  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp

@@ -220 +220 @@
 
 #if USE(AUDIO_SESSION)
-    if (activeAudioSessionRequired() && !AudioSession::sharedSession().tryToSetActive(true)) {
-        ALWAYS_LOG(LOGIDENTIFIER, session.logIdentifier(), " returning false failed to set active AudioSession");
-        return false;
-    }
-
-    m_becameActive = true;
+    if (activeAudioSessionRequired()) {
+        if (!AudioSession::sharedSession().tryToSetActive(true)) {
+            ALWAYS_LOG(LOGIDENTIFIER, session.logIdentifier(), " returning false failed to set active AudioSession");
+            return false;
+        }
+
+        ALWAYS_LOG(LOGIDENTIFIER, session.logIdentifier(), " sucessfully activated AudioSession");
+        m_becameActive = true;
+    }
 #endif