Changeset 244495 in webkit

Timestamp:

Apr 21, 2019 5:24:03 PM (5 years ago)

Author:

Darin Adler

Message:

WHLSLPrepare.cpp always recompiles, even if nothing was changed
​https://bugs.webkit.org/show_bug.cgi?id=197151

Reviewed by Dan Bernstein.

• DerivedSources-input.xcfilelist: Script updated this automatically after

DerivedSources.make was corrected.

• DerivedSources-output.xcfilelist: Ditto, although I had to manually remove

one bogus leftover reference to WHLSLStandardLibrary.cpp.

• DerivedSources.make: Updated the rule that builds WHSLStandardLibrary.h to

no longer refer to nonexistent WHLSLStandardLibrary.cpp. Because the dependency
was on a file that was never created, the rule to regenerate WHSLStandardLibrary.h
was running on every build, instead of only when one of the dependencies changed.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• DerivedSources-input.xcfilelist (modified) (2 diffs)
• DerivedSources-output.xcfilelist (modified) (1 diff)
• DerivedSources.make (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-04-21  Darin Adler  <darin@apple.com>
+
+        WHLSLPrepare.cpp always recompiles, even if nothing was changed
+        https://bugs.webkit.org/show_bug.cgi?id=197151
+
+        Reviewed by Dan Bernstein.
+
+        * DerivedSources-input.xcfilelist: Script updated this automatically after
+        DerivedSources.make was corrected.
+        * DerivedSources-output.xcfilelist: Ditto, although I had to manually remove
+        one bogus leftover reference to WHLSLStandardLibrary.cpp.
+
+        * DerivedSources.make: Updated the rule that builds WHSLStandardLibrary.h to
+        no longer refer to nonexistent WHLSLStandardLibrary.cpp. Because the dependency
+        was on a file that was never created, the rule to regenerate WHSLStandardLibrary.h
+        was running on every build, instead of only when one of the dependencies changed.
+
 2019-04-20  Said Abou-Hallawa  <said@apple.com>
 

trunk/Source/WebCore/DerivedSources-input.xcfilelist

@@ -16 +16 @@
 $(JAVASCRIPTCORE_PRIVATE_HEADERS_DIR)/make-js-file-arrays.py
 $(JAVASCRIPTCORE_PRIVATE_HEADERS_DIR)/wkbuiltins.py
+$(JAVASCRIPTCORE_PRIVATE_HEADERS_DIR)/xxd.pl
 $(PROJECT_DIR)/Configurations/FeatureDefines.xcconfig
 $(PROJECT_DIR)/DerivedSources.make
@@ -342 +343 @@
 $(PROJECT_DIR)/Modules/webgpu/GPUVertexAttributeDescriptor.idl
 $(PROJECT_DIR)/Modules/webgpu/GPUVertexInputDescriptor.idl
+$(PROJECT_DIR)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt
 $(PROJECT_DIR)/Modules/webgpu/WebGPU.idl
 $(PROJECT_DIR)/Modules/webgpu/WebGPUAdapter.idl

trunk/Source/WebCore/DerivedSources-output.xcfilelist

@@ -2085 +2085 @@
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/UserAgentScriptsData.cpp
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/UserAgentStyleSheets.h
-$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WHLSLStandardLibrary.cpp
+$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WHLSLStandardLibrary.h
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCoreJSBuiltinInternals.cpp
 $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCoreJSBuiltinInternals.h

trunk/Source/WebCore/DerivedSources.make

@@ -1634 +1634 @@
 # WHLSL Standard Library
 
-all : WHLSLStandardLibrary.cpp
-
-WHLSLStandardLibrary.cpp : $(JavaScriptCore_SCRIPTS_DIR)/xxd.pl $(WebCore)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt
-        $(PERL) $(JavaScriptCore_SCRIPTS_DIR)/xxd.pl WHLSLStandardLibrary $(WebCore)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt WHLSLStandardLibrary.h
+all : WHLSLStandardLibrary.h
+
+WHLSLStandardLibrary.h : $(JavaScriptCore_SCRIPTS_DIR)/xxd.pl $(WebCore)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt
+        $(PERL) $(JavaScriptCore_SCRIPTS_DIR)/xxd.pl WHLSLStandardLibrary $(WebCore)/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt $<
 
 # --------