Changeset 244503 in webkit

Timestamp:

Apr 22, 2019 11:17:33 AM (5 years ago)

Author:

Said Abou-Hallawa

Message:

Mark SVGStringList properties '[SameObject]' in the IDL files
Followup to ​https://bugs.webkit.org/show_bug.cgi?id=197137

Patch by Said Abou-Hallawa <Said Abou-Hallawa> on 2019-04-22
Reviewed by Darin Adler.

The SVG elements do not create tear-off wrappers for SVGStrigList DOM
objects anymore. Instead they return Ref pointers to the same RefCounted
objects. So they should be marked '[SameObject]' in their IDL files.

• svg/SVGTests.idl:
• svg/SVGViewElement.idl:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• svg/SVGTests.idl (modified) (1 diff)
• svg/SVGViewElement.idl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-04-22  Said Abou-Hallawa  <said@apple.com>
+
+        Mark SVGStringList properties '[SameObject]' in the IDL files
+        Followup to https://bugs.webkit.org/show_bug.cgi?id=197137
+
+        Reviewed by Darin Adler.
+
+        The SVG elements do not create tear-off wrappers for SVGStrigList DOM
+        objects anymore. Instead they return Ref pointers to the same RefCounted
+        objects. So they should be marked '[SameObject]' in their IDL files.
+
+        * svg/SVGTests.idl:
+        * svg/SVGViewElement.idl:
+
 2019-04-22  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/svg/SVGTests.idl

@@ -29 +29 @@
     SuppressToJSObject,
 ] interface SVGTests {
-    readonly attribute SVGStringList requiredFeatures;
-    readonly attribute SVGStringList requiredExtensions;
-    readonly attribute SVGStringList systemLanguage;
+    [SameObject] readonly attribute SVGStringList requiredFeatures;
+    [SameObject] readonly attribute SVGStringList requiredExtensions;
+    [SameObject] readonly attribute SVGStringList systemLanguage;
 
     // FIXME: Using "undefined" as default parameter value is wrong.

trunk/Source/WebCore/svg/SVGViewElement.idl

@@ -25 +25 @@
 
 interface SVGViewElement : SVGElement {
-    readonly attribute SVGStringList viewTarget;
+    [SameObject] readonly attribute SVGStringList viewTarget;
 };