Changeset 244549 in webkit


Ignore:
Timestamp:
Apr 23, 2019 10:54:35 AM (5 years ago)
Author:
aakash_jain@apple.com
Message:

[ews-build] Use explicit imports instead of wildcard imports
​https://bugs.webkit.org/show_bug.cgi?id=197194

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-build/factories.py:
  • BuildSlaveSupport/ews-build/loadConfig.py:
  • BuildSlaveSupport/ews-build/steps_unittest.py:
Location:
trunk/Tools
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/ews-build/factories.py

    r244532 r244549  
    2525from buildbot.steps import trigger
    2626
    27 from steps import *
     27from steps import (ApplyPatch, CheckOutSource, CheckPatchRelevance, CheckStyle,
     28                   CompileJSCOnly, CompileJSCOnlyToT, CompileWebKit, ConfigureBuild,
     29                   DownloadBuiltProduct, ExtractBuiltProduct, KillOldProcesses,
     30                   PrintConfiguration, ReRunJavaScriptCoreTests, RunAPITests, RunBindingsTests,
     31                   RunJavaScriptCoreTests, RunJavaScriptCoreTestsToT, RunWebKit1Tests, RunWebKitPerlTests,
     32                   RunWebKitPyTests, RunWebKitTests, UnApplyPatchIfRequired, ValidatePatch)
    2833
    2934

  • trunk/Tools/BuildSlaveSupport/ews-build/loadConfig.py

    r243759 r244549  
    1 # Copyright (C) 2018 Apple Inc. All rights reserved.
     1# Copyright (C) 2018-2019 Apple Inc. All rights reserved.
    22#
    33# Redistribution and use in source and binary forms, with or without
    … …  
    3131from buildbot.util import identifiers as buildbot_identifiers
    3232
    33 from factories import *
     33from factories import (APITestsFactory, BindingsFactory, BuildFactory, Factory, GTKFactory,
     34                       JSCTestsFactory, StyleFactory, TestFactory, WPEFactory, WebKitPerlFactory,
     35                       WebKitPyFactory, WinCairoFactory, WindowsFactory, iOSBuildFactory, iOSTestsFactory,
     36                       macOSBuildFactory, macOSWK1Factory, macOSWK2Factory)
    3437
    3538BUILDER_NAME_LENGTH_LIMIT = 70

  • trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

    r244548 r244549  
    1 # Copyright (C) 2018 Apple Inc. All rights reserved.
     1# Copyright (C) 2018-2019 Apple Inc. All rights reserved.
    22#
    33# Redistribution and use in source and binary forms, with or without
    … …  
    3535from twisted.trial import unittest
    3636
    37 from steps import *
     37from steps import (AnalyzeAPITestsResults, ApplyPatch, ArchiveBuiltProduct, ArchiveTestResults,
     38                   CheckOutSource, CheckPatchRelevance, CheckStyle, CleanBuild, CleanWorkingDirectory,
     39                   CompileJSCOnly, CompileJSCOnlyToT, CompileWebKit, CompileWebKitToT, ConfigureBuild,
     40                   DownloadBuiltProduct, ExtractBuiltProduct, ExtractTestResults, KillOldProcesses,
     41                   PrintConfiguration, ReRunAPITests, ReRunJavaScriptCoreTests, RunAPITests, RunAPITestsWithoutPatch,
     42                   RunBindingsTests, RunJavaScriptCoreTests, RunJavaScriptCoreTestsToT, RunWebKit1Tests, RunWebKitPerlTests,
     43                   RunWebKitPyTests, RunWebKitTests, TestWithFailureCount, Trigger, UnApplyPatchIfRequired, UploadBuiltProduct,
     44                   UploadTestResults, ValidatePatch)
    3845
    3946# Workaround for https://github.com/buildbot/buildbot/issues/4669

  • trunk/Tools/ChangeLog

    r244548 r244549  
     12019-04-23  Aakash Jain  <aakash_jain@apple.com>
     2
     3        [ews-build] Use explicit imports instead of wildcard imports
     4        https://bugs.webkit.org/show_bug.cgi?id=197194
     5
     6        Reviewed by Lucas Forschler.
     7
     8        * BuildSlaveSupport/ews-build/factories.py:
     9        * BuildSlaveSupport/ews-build/loadConfig.py:
     10        * BuildSlaveSupport/ews-build/steps_unittest.py:
     11
    1122019-04-23  Aakash Jain  <aakash_jain@apple.com>
    213
Note: See TracChangeset for help on using the changeset viewer.