Changeset 244551 in webkit

Timestamp:

Apr 23, 2019 11:02:55 AM (5 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-build] Add unit tests for UnApplyPatchIfRequired
​https://bugs.webkit.org/show_bug.cgi?id=197197

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-build/steps_unittest.py:

(TestUnApplyPatchIfRequired):
(TestUnApplyPatchIfRequired.test_success):
(TestUnApplyPatchIfRequired.test_failure):
(TestUnApplyPatchIfRequired.test_skip):

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps_unittest.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

@@ -864 +864 @@
         )
         self.expectOutcome(result=FAILURE, state_string='Cleaned working directory (failure)')
+        return self.runStep()
+
+
+class TestUnApplyPatchIfRequired(BuildStepMixinAdditions, unittest.TestCase):
+    def setUp(self):
+        self.longMessage = True
+        return self.setUpBuildStep()
+
+    def tearDown(self):
+        return self.tearDownBuildStep()
+
+    def test_success(self):
+        self.setupStep(UnApplyPatchIfRequired())
+        self.setProperty('patchFailedToBuild', True)
+        self.expectHidden(False)
+        self.expectRemoteCommands(
+            ExpectShell(workdir='wkdir',
+                        command=['Tools/Scripts/clean-webkit'],
+                        )
+            + 0,
+        )
+        self.expectOutcome(result=SUCCESS, state_string='Unapplied patch')
+        return self.runStep()
+
+    def test_failure(self):
+        self.setupStep(UnApplyPatchIfRequired())
+        self.setProperty('patchFailedToBuild', True)
+        self.expectHidden(False)
+        self.expectRemoteCommands(
+            ExpectShell(workdir='wkdir',
+                        command=['Tools/Scripts/clean-webkit'],
+                        )
+            + ExpectShell.log('stdio', stdout='Unexpected failure.')
+            + 2,
+        )
+        self.expectOutcome(result=FAILURE, state_string='Unapplied patch (failure)')
+        return self.runStep()
+
+    def test_skip(self):
+        self.setupStep(UnApplyPatchIfRequired())
+        self.expectHidden(True)
+        self.expectOutcome(result=SKIPPED, state_string='Unapplied patch (skipped)')
         return self.runStep()
 

trunk/Tools/ChangeLog

@@ +1 @@
+2019-04-23  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] Add unit tests for UnApplyPatchIfRequired
+        https://bugs.webkit.org/show_bug.cgi?id=197197
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-build/steps_unittest.py:
+        (TestUnApplyPatchIfRequired):
+        (TestUnApplyPatchIfRequired.test_success):
+        (TestUnApplyPatchIfRequired.test_failure):
+        (TestUnApplyPatchIfRequired.test_skip):
+
 2019-04-23  Aakash Jain  <aakash_jain@apple.com>