Changeset 244587 in webkit


Ignore:
Timestamp:
Apr 24, 2019 7:47:33 AM (5 years ago)
Author:
Philippe Normand
Message:

[GTK][GStreamer] Flaky ASSERTION FAILED: m_lock.isHeld() in TextureMapperPlatformLayerProxy
https://bugs.webkit.org/show_bug.cgi?id=196739

Reviewed by Xabier Rodriguez-Calvar.

The crash was triggered because m_videoDecoderPlatform not being
explicitely set, its value would be inferred as one of the enum
class values. Making it Optional avoids this issue.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r244584 r244587  
     12019-04-24  Philippe Normand  <pnormand@igalia.com>
     2
     3        [GTK][GStreamer] Flaky ASSERTION FAILED: m_lock.isHeld() in TextureMapperPlatformLayerProxy
     4        https://bugs.webkit.org/show_bug.cgi?id=196739
     5
     6        Reviewed by Xabier Rodriguez-Calvar.
     7
     8        The crash was triggered because m_videoDecoderPlatform not being
     9        explicitely set, its value would be inferred as one of the enum
     10        class values. Making it Optional avoids this issue.
     11
     12        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
     13
    1142019-04-24  Philippe Normand  <pnormand@igalia.com>
    215
  • trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h

    r243644 r244587  
    291291
    292292    enum class WebKitGstVideoDecoderPlatform { ImxVPU, Video4Linux };
    293 
    294     WebKitGstVideoDecoderPlatform m_videoDecoderPlatform;
     293    Optional<WebKitGstVideoDecoderPlatform> m_videoDecoderPlatform;
    295294};
    296295
Note: See TracChangeset for help on using the changeset viewer.