Changeset 244632 in webkit


Ignore:
Timestamp:
Apr 24, 2019 6:11:00 PM (5 years ago)
Author:
youenn@apple.com
Message:

Do not restart WebRTC stats timer if backend is stopped
https://bugs.webkit.org/show_bug.cgi?id=197257
<rdar://problem/50095879>

Reviewed by Eric Carlson.

We used to stop and reschedule the stat gathering timer in case the
gathering delay is changing. Timer should not be rescheduled if the backend is stopped.

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r244631 r244632  
     12019-04-24  Youenn Fablet  <youenn@apple.com>
     2
     3        Do not restart WebRTC stats timer if backend is stopped
     4        https://bugs.webkit.org/show_bug.cgi?id=197257
     5        <rdar://problem/50095879>
     6
     7        Reviewed by Eric Carlson.
     8
     9        We used to stop and reschedule the stat gathering timer in case the
     10        gathering delay is changing. Timer should not be rescheduled if the backend is stopped.
     11
     12        * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
     13        (WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):
     14
    1152019-04-24  Andres Gonzalez  <andresg_22@apple.com>
    216
  • trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp

    r244034 r244632  
    848848
    849849    callOnMainThread([protectedThis = makeRef(*this), this, timestamp, report] {
    850         if (m_statsLogTimer.repeatInterval() != statsLogInterval(timestamp)) {
     850        if (m_backend && m_statsLogTimer.repeatInterval() != statsLogInterval(timestamp)) {
    851851            m_statsLogTimer.stop();
    852852            m_statsLogTimer.startRepeating(statsLogInterval(timestamp));
Note: See TracChangeset for help on using the changeset viewer.