Changeset 244641 in webkit
- Timestamp:
- Apr 25, 2019 12:52:36 AM (5 years ago)
- Location:
- trunk
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r244635 r244641 1 2019-04-25 Philippe Normand <pnormand@igalia.com> 2 3 [GStreamer] gst_element_get_state: assertion 'GST_IS_ELEMENT (element)' failed in WebCore::MediaPlayerPrivateGStreamer::paused 4 https://bugs.webkit.org/show_bug.cgi?id=196691 5 6 Reviewed by Eric Carlson. 7 8 Unflag test no longer crashing. 9 10 * platform/gtk/TestExpectations: 11 * platform/gtk/fast/replaced/border-radius-clip-expected.txt: 12 1 13 2019-04-24 Carlos Garcia Campos <cgarcia@igalia.com> 2 14 -
trunk/LayoutTests/platform/gtk/TestExpectations
r244635 r244641 1642 1642 webkit.org/b/133869 media/video-seek-after-end.html [ Failure Pass ] 1643 1643 1644 # Crash is webkit.org/b/176802 1645 webkit.org/b/36642 fast/replaced/border-radius-clip.html [ Failure Pass Crash ] 1644 webkit.org/b/36642 fast/replaced/border-radius-clip.html [ Failure Pass ] 1646 1645 1647 1646 webkit.org/b/134573 media/track/audio-track.html [ Failure Timeout Pass ] -
trunk/LayoutTests/platform/gtk/fast/replaced/border-radius-clip-expected.txt
r159017 r244641 1 layer at (0,0) size 785x9 471 layer at (0,0) size 785x952 2 2 RenderView at (0,0) size 785x600 3 layer at (0,0) size 785x92 34 RenderBlock {HTML} at (0,0) size 785x92 35 RenderBody {BODY} at (8,8) size 769x9 073 layer at (0,0) size 785x928 4 RenderBlock {HTML} at (0,0) size 785x928 5 RenderBody {BODY} at (8,8) size 769x912 6 6 RenderText {#text} at (0,0) size 457x17 7 7 text run at (0,0) width 457: "All of the replaced elements below should be clipped to a border-radius. " 8 8 RenderBR {BR} at (0,0) size 0x0 9 RenderImage {IMG} at (0,1 7) size 100x10010 RenderText {#text} at (100,10 3) size 4x1711 text run at (100,10 3) width 4: " "9 RenderImage {IMG} at (0,18) size 100x100 10 RenderText {#text} at (100,104) size 4x17 11 text run at (100,104) width 4: " " 12 12 RenderBR {BR} at (0,0) size 0x0 13 RenderImage {INPUT} at (0,12 0) size 100x10014 RenderText {#text} at (100,20 6) size 4x1715 text run at (100,20 6) width 4: " "13 RenderImage {INPUT} at (0,122) size 100x100 14 RenderText {#text} at (100,208) size 4x17 15 text run at (100,208) width 4: " " 16 16 RenderBR {BR} at (0,0) size 0x0 17 RenderIFrame {IFRAME} at (0,22 3) size 304x154 [border: (2px inset #000000)]17 RenderIFrame {IFRAME} at (0,226) size 304x154 [border: (2px inset #000000)] 18 18 layer at (0,0) size 300x150 19 19 RenderView at (0,0) size 300x150 … … 22 22 RenderBody {BODY} at (0,0) size 300x150 23 23 RenderImage {IMG} at (0,0) size 100x100 24 RenderText {#text} at (304,36 3) size 4x1725 text run at (304,36 3) width 4: " "24 RenderText {#text} at (304,366) size 4x17 25 text run at (304,366) width 4: " " 26 26 RenderBR {BR} at (0,0) size 0x0 27 RenderText {#text} at (300,5 16) size 4x1728 text run at (300,5 16) width 4: " "27 RenderText {#text} at (300,520) size 4x17 28 text run at (300,520) width 4: " " 29 29 RenderBR {BR} at (0,0) size 0x0 30 RenderEmbeddedObject {EMBED} at (0,53 3) size 556x406 [bgcolor=#00FF00] [border: (3px solid #000000)]30 RenderEmbeddedObject {EMBED} at (0,538) size 556x406 [bgcolor=#00FF00] [border: (3px solid #000000)] 31 31 RenderText {#text} at (0,0) size 0x0 32 layer at (8,3 88) size 300x15033 RenderVideo {VIDEO} at (0,38 0) size 300x15032 layer at (8,392) size 300x150 33 RenderVideo {VIDEO} at (0,384) size 300x150 -
trunk/Source/WebCore/ChangeLog
r244640 r244641 1 2019-04-25 Philippe Normand <pnormand@igalia.com> 2 3 [GStreamer] gst_element_get_state: assertion 'GST_IS_ELEMENT (element)' failed in WebCore::MediaPlayerPrivateGStreamer::paused 4 https://bugs.webkit.org/show_bug.cgi?id=196691 5 6 Reviewed by Eric Carlson. 7 8 For gif assets, fail media loading early and notify the 9 MediaPlayer by setting both network and ready states, so that the 10 MediaPlayer will try with with the next media engine or pass the 11 error to HTMLMediaElement if there are none. 12 13 * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: 14 (WebCore::MediaPlayerPrivateGStreamer::loadFull): 15 (WebCore::MediaPlayerPrivateGStreamer::loadingFailed): 16 * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: 17 1 18 2019-04-25 Philippe Normand <pnormand@igalia.com> 2 19 -
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
r244584 r244641 276 276 void MediaPlayerPrivateGStreamer::loadFull(const String& urlString, const String& pipelineName) 277 277 { 278 // FIXME: This method is still called even if supportsType() returned279 // IsNotSupported. This would deserve more investigation but meanwhile make280 // sure we don't ever try to play animated gif assets.281 278 if (m_player->contentMIMEType() == "image/gif") { 282 loadingFailed(MediaPlayer::FormatError );279 loadingFailed(MediaPlayer::FormatError, MediaPlayer::HaveNothing, true); 283 280 return; 284 281 } … … 2223 2220 } 2224 2221 2225 void MediaPlayerPrivateGStreamer::loadingFailed(MediaPlayer::NetworkState error)2226 { 2227 GST_WARNING("Loading failed, error: % d", error);2222 void MediaPlayerPrivateGStreamer::loadingFailed(MediaPlayer::NetworkState networkError, MediaPlayer::ReadyState readyState, bool forceNotifications) 2223 { 2224 GST_WARNING("Loading failed, error: %s", convertEnumerationToString(networkError).utf8().data()); 2228 2225 2229 2226 m_errorOccured = true; 2230 if ( m_networkState != error) {2231 m_networkState = error;2227 if (forceNotifications || m_networkState != networkError) { 2228 m_networkState = networkError; 2232 2229 m_player->networkStateChanged(); 2233 2230 } 2234 if ( m_readyState != MediaPlayer::HaveNothing) {2235 m_readyState = MediaPlayer::HaveNothing;2231 if (forceNotifications || m_readyState != readyState) { 2232 m_readyState = readyState; 2236 2233 m_player->readyStateChanged(); 2237 2234 } -
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h
r244584 r244641 117 117 void didEnd(); 118 118 virtual void durationChanged(); 119 void loadingFailed(MediaPlayer::NetworkState );119 void loadingFailed(MediaPlayer::NetworkState, MediaPlayer::ReadyState = MediaPlayer::HaveNothing, bool forceNotifications = false); 120 120 121 121 virtual void sourceSetup(GstElement*);
Note: See TracChangeset
for help on using the changeset viewer.