Changeset 244655 in webkit

Timestamp:

Apr 25, 2019 11:49:00 AM (5 years ago)

Author:

beidson@apple.com

Message:

REGRESSION (243388): WebProcess::shouldFreezeOnSuspension() decision is flipped
<rdar://problem/49755494> and ​https://bugs.webkit.org/show_bug.cgi?id=197284

Reviewed by Chris Dumez.

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::shouldFreezeOnSuspension const): If any non-suspended pages are in the process it should

be eligible. Only if all pages are suspended should it be jetsam-able.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/cocoa/WebProcessCocoa.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-04-25  Brady Eidson  <beidson@apple.com>
+
+        REGRESSION (243388): WebProcess::shouldFreezeOnSuspension() decision is flipped
+        <rdar://problem/49755494> and https://bugs.webkit.org/show_bug.cgi?id=197284
+
+        Reviewed by Chris Dumez.
+
+        * WebProcess/cocoa/WebProcessCocoa.mm:
+        (WebKit::WebProcess::shouldFreezeOnSuspension const): If any non-suspended pages are in the process it should
+          be eligible. Only if all pages are suspended should it be jetsam-able.
+
 2019-04-25  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

@@ -734 +734 @@
     for (auto& page : m_pageMap.values()) {
         if (!page->isSuspended())
-            return false;
-    }
-
-    return true;
+            return true;
+    }
+
+    // Since all of the pages in this process were suspended, we should not bother freezing it.
+    return false;
 }