Changeset 244667 in webkit

Timestamp:

Apr 25, 2019 3:09:27 PM (5 years ago)

Author:

timothy@apple.com

Message:

Only send a synthetic mouse out event if synthetic mouse move events were sent.
​https://bugs.webkit.org/show_bug.cgi?id=197295
rdar://problem/49040233

Reviewed by Zalan Bujtas.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::completeSyntheticClick):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/ios/WebPageIOS.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-04-25  Timothy Hatcher  <timothy@apple.com>
+
+        Only send a synthetic mouse out event if synthetic mouse move events were sent.
+        https://bugs.webkit.org/show_bug.cgi?id=197295
+        rdar://problem/49040233
+
+        Reviewed by Zalan Bujtas.
+
+        * WebProcess/WebPage/ios/WebPageIOS.mm:
+        (WebKit::WebPage::completeSyntheticClick):
+
 2019-04-25  Timothy Hatcher  <timothy@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

@@ -690 +690 @@
         elementDidRefocus(*newFocusedElement);
 
-    if (!tapWasHandled && nodeRespondingToClick.document().frame())
+    // Only send a synthetic mouse out event if synthetic mouse move events were sent; this is true when ContentChangeObserver is enabled.
+    if (nodeRespondingToClick.document().settings().contentChangeObserverEnabled() && !tapWasHandled && nodeRespondingToClick.document().frame())
         nodeRespondingToClick.document().frame()->eventHandler().dispatchSyntheticMouseOut(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::NoType, 0, shiftKey, ctrlKey, altKey, metaKey, WallTime::now(), 0, WebCore::NoTap));
+
     if (m_isClosed)
         return;