Changeset 244689 in webkit


Ignore:
Timestamp:
Apr 26, 2019 9:29:15 AM (5 years ago)
Author:
youenn@apple.com
Message:

[Mac WK2 iOS Sim] Layout Test imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=196633
<rdar://problem/49627667>

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt:

Source/WebCore:

Use formula defined in ​https://w3c.github.io/webrtc-stats/#dom-rtcrtpcontributingsourcestats-audiolevel
to compute the audio level from the RTP header information.
Covered by rebased test.

  • Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp:

(WebCore::fillRTCRtpContributingSource):

LayoutTests:

  • platform/mac-wk2/TestExpectations:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r244685 r244689  
     12019-04-26  Youenn Fablet  <youenn@apple.com>
     2
     3        [Mac WK2 iOS Sim] Layout Test imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html is a flaky failure
     4        https://bugs.webkit.org/show_bug.cgi?id=196633
     5        <rdar://problem/49627667>
     6
     7        Reviewed by Alex Christensen.
     8
     9        * platform/mac-wk2/TestExpectations:
     10
    1112019-04-26  Per Arne Vollan  <pvollan@apple.com>
    212

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r244515 r244689  
     12019-04-26  Youenn Fablet  <youenn@apple.com>
     2
     3        [Mac WK2 iOS Sim] Layout Test imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html is a flaky failure
     4        https://bugs.webkit.org/show_bug.cgi?id=196633
     5        <rdar://problem/49627667>
     6
     7        Reviewed by Alex Christensen.
     8
     9        * web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt:
     10
    1112019-04-22  Youenn Fablet  <youenn@apple.com>
    212

  • trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https-expected.txt

    r243041 r244689  
    1010FAIL [video] RTCRtpSynchronizationSource.timestamp is comparable to performance.timeOrigin + performance.now() assert_true: expected true got false
    1111PASS [video] RTCRtpSynchronizationSource.source is a number
    12 FAIL [audio-only] RTCRtpSynchronizationSource.audioLevel is a number [0, 1] assert_less_than_equal: expected a number less than or equal to 1 but got 23
     12PASS [audio-only] RTCRtpSynchronizationSource.audioLevel is a number [0, 1]
    1313FAIL [audio-only] RTCRtpSynchronizationSource.voiceActivityFlag is a boolean assert_equals: expected "boolean" but got "undefined"
    1414

  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r244674 r244689  
    939939webkit.org/b/194164 http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-user-interaction-but-access-from-wrong-frame.html [ Pass Timeout ]
    940940
    941 webkit.org/b/196633 imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html [ Pass Failure ]
    942 
    943941webkit.org/b/195961 [ Debug ] imported/w3c/IndexedDB-private-browsing/idbobjectstore_createIndex7-event_order.html [ Pass Failure ]
    944942webkit.org/b/195961 [ Debug ] imported/w3c/IndexedDB-private-browsing/idbobjectstore_createIndex6-event_order.html [ Pass Failure ]

  • trunk/Source/WebCore/ChangeLog

    r244687 r244689  
     12019-04-26  Youenn Fablet  <youenn@apple.com>
     2
     3        [Mac WK2 iOS Sim] Layout Test imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html is a flaky failure
     4        https://bugs.webkit.org/show_bug.cgi?id=196633
     5        <rdar://problem/49627667>
     6
     7        Reviewed by Alex Christensen.
     8
     9        Use formula defined in https://w3c.github.io/webrtc-stats/#dom-rtcrtpcontributingsourcestats-audiolevel
     10        to compute the audio level from the RTP header information.
     11        Covered by rebased test.
     12
     13        * Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp:
     14        (WebCore::fillRTCRtpContributingSource):
     15
    1162019-04-26  Sihui Liu  <sihui_liu@apple.com>
    217

  • trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp

    r237585 r244689  
    4242    source.source = rtcSource.source_id();
    4343    if (rtcSource.audio_level())
    44         source.audioLevel = *rtcSource.audio_level();
     44        source.audioLevel = (*rtcSource.audio_level() == 127) ? 0 : pow(10, -*rtcSource.audio_level() / 20);
    4545}
    4646
Note: See TracChangeset for help on using the changeset viewer.