Context Navigation

← Previous Changeset
Next Changeset →

Changeset 244713 in webkit

Timestamp:

Apr 26, 2019 5:37:40 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r244708.
https://bugs.webkit.org/show_bug.cgi?id=197334

"Broke the debug build" (Requested by rmorisset on #webkit).

Reverted changeset:

"All prototypes should call didBecomePrototype()"
https://bugs.webkit.org/show_bug.cgi?id=196315
https://trac.webkit.org/changeset/244708

Location:

trunk

Files:

: 1 deleted
: 99 edited

JSTests/ChangeLog (modified) (1 diff)
JSTests/stress/function-prototype-indexed-accessor.js (deleted)
Source/JavaScriptCore/ChangeLog (modified) (1 diff)
Source/JavaScriptCore/runtime/BigIntPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/BooleanPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/DatePrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/ErrorConstructor.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/ErrorPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/FunctionConstructor.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/FunctionPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/IntlCollatorPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/IntlDateTimeFormatPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/IntlNumberFormatPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/IntlPluralRulesPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/JSArrayBufferPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/JSDataViewPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototypeInlines.h (modified) (1 diff)
Source/JavaScriptCore/runtime/JSGlobalObject.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/JSPromisePrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/JSTypedArrayViewConstructor.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/JSTypedArrayViewPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/NumberPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/RegExpPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/StringPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/runtime/Structure.cpp (modified) (2 diffs)
Source/JavaScriptCore/runtime/Structure.h (modified) (2 diffs)
Source/JavaScriptCore/runtime/SymbolPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/wasm/js/WebAssemblyCompileErrorPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/wasm/js/WebAssemblyInstancePrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/wasm/js/WebAssemblyLinkErrorPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/wasm/js/WebAssemblyMemoryPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/wasm/js/WebAssemblyModulePrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/wasm/js/WebAssemblyPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/wasm/js/WebAssemblyRuntimeErrorPrototype.cpp (modified) (1 diff)
Source/JavaScriptCore/wasm/js/WebAssemblyTablePrototype.cpp (modified) (1 diff)
Source/WebCore/ChangeLog (modified) (1 diff)
Source/WebCore/bindings/js/JSWindowProxy.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (modified) (2 diffs)
Source/WebCore/bindings/scripts/test/JS/JSInterfaceName.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSMapLike.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSReadOnlyMapLike.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestCEReactions.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestCallTracer.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.cpp (modified) (2 diffs)
Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp (modified) (2 diffs)
Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp (modified) (2 diffs)
Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.h (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestIterable.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp (modified) (2 diffs)
Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestPluginInterface.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp (modified) (2 diffs)
Source/WebCore/bindings/scripts/test/JS/JSTestSerialization.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.cpp (modified) (2 diffs)
Source/WebCore/bindings/scripts/test/JS/JSTestSerializationInherit.cpp (modified) (2 diffs)
Source/WebCore/bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp (modified) (2 diffs)
Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestStringifier.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp (modified) (1 diff)
Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/JSTests/ChangeLog

-                      r244711
+                      r244713
+-04-26  Commit Queue  <commit-queue@webkit.org>
+        Unreviewed, rolling out r244708.
+        https://bugs.webkit.org/show_bug.cgi?id=197334
+        "Broke the debug build" (Requested by rmorisset on #webkit).
+        Reverted changeset:
+        "All prototypes should call didBecomePrototype()"
+        https://bugs.webkit.org/show_bug.cgi?id=196315
+        https://trac.webkit.org/changeset/244708
 -04-25  Yusuke Suzuki  <ysuzuki@apple.com>

trunk/Source/JavaScriptCore/ChangeLog

-                      r244712
+                      r244713
+-04-26  Commit Queue  <commit-queue@webkit.org>
+        Unreviewed, rolling out r244708.
+        https://bugs.webkit.org/show_bug.cgi?id=197334
+        "Broke the debug build" (Requested by rmorisset on #webkit).
+        Reverted changeset:
+        "All prototypes should call didBecomePrototype()"
+        https://bugs.webkit.org/show_bug.cgi?id=196315
+        https://trac.webkit.org/changeset/244708
 -04-26  Don Olmstead  <don.olmstead@sony.com>

trunk/Source/JavaScriptCore/runtime/BigIntPrototype.cpp

r244708	r244713
74	74	ASSERT(inherits(vm, info()));
75	75	putDirectWithoutTransition(vm, vm.propertyNames->toStringTagSymbol, jsString(&vm, "BigInt"), PropertyAttribute::DontEnum \| PropertyAttribute::ReadOnly);
76		~~didBecomePrototype();~~
77	76	}
78	77

trunk/Source/JavaScriptCore/runtime/BooleanPrototype.cpp

r244708	r244713
60	60	Base::finishCreation(vm);
61	61	setInternalValue(vm, jsBoolean(false));
62		~~didBecomePrototype();~~
63	62
64	63	ASSERT(inherits(vm, info()));

trunk/Source/JavaScriptCore/runtime/DatePrototype.cpp

r244708	r244713
516	516	JSFunction* toPrimitiveFunction = JSFunction::create(vm, globalObject, 1, "[Symbol.toPrimitive]"_s, dateProtoFuncToPrimitiveSymbol, NoIntrinsic);
517	517	putDirectWithoutTransition(vm, vm.propertyNames->toPrimitiveSymbol, toPrimitiveFunction, PropertyAttribute::DontEnum \| PropertyAttribute::ReadOnly);
518		~~didBecomePrototype();~~
519	518
520	519	// The constructor will be added later, after DateConstructor has been built.

trunk/Source/JavaScriptCore/runtime/ErrorConstructor.cpp

r244708	r244713
49	49	putDirectWithoutTransition(vm, vm.propertyNames->length, jsNumber(1), PropertyAttribute::DontEnum \| PropertyAttribute::ReadOnly);
50	50	putDirectWithoutTransition(vm, vm.propertyNames->stackTraceLimit, jsNumber(globalObject(vm)->stackTraceLimit().valueOr(Options::defaultErrorStackTraceLimit())), static_cast<unsigned>(PropertyAttribute::None));
51		~~didBecomePrototype();~~
52	51	}
53	52

trunk/Source/JavaScriptCore/runtime/ErrorPrototype.cpp

r244708	r244713
67	67	putDirectWithoutTransition(vm, vm.propertyNames->name, jsString(&vm, name), static_cast<unsigned>(PropertyAttribute::DontEnum));
68	68	putDirectWithoutTransition(vm, vm.propertyNames->message, jsEmptyString(&vm), static_cast<unsigned>(PropertyAttribute::DontEnum));
69		~~didBecomePrototype();~~
70	69	}
71	70

trunk/Source/JavaScriptCore/runtime/FunctionConstructor.cpp

r244708	r244713
62	62	putDirectWithoutTransition(vm, vm.propertyNames->prototype, functionPrototype, PropertyAttribute::DontEnum \| PropertyAttribute::DontDelete \| PropertyAttribute::ReadOnly);
63	63	putDirectWithoutTransition(vm, vm.propertyNames->length, jsNumber(1), PropertyAttribute::ReadOnly \| PropertyAttribute::DontEnum);
64		~~didBecomePrototype();~~
65	64	}
66	65

trunk/Source/JavaScriptCore/runtime/FunctionPrototype.cpp

r244708	r244713
55	55	Base::finishCreation(vm, name, NameVisibility::Visible, NameAdditionMode::WithoutStructureTransition);
56	56	putDirectWithoutTransition(vm, vm.propertyNames->length, jsNumber(0), PropertyAttribute::DontDelete \| PropertyAttribute::ReadOnly \| PropertyAttribute::DontEnum);
57		~~didBecomePrototype();~~
58	57	}
59	58

trunk/Source/JavaScriptCore/runtime/IntlCollatorPrototype.cpp

r244708	r244713
77	77
78	78	putDirectWithoutTransition(vm, vm.propertyNames->toStringTagSymbol, jsString(&vm, "Object"), PropertyAttribute::DontEnum \| PropertyAttribute::ReadOnly);
79		~~didBecomePrototype();~~
80	79	}
81	80

trunk/Source/JavaScriptCore/runtime/IntlDateTimeFormatPrototype.cpp

r244708	r244713
91	91
92	92	putDirectWithoutTransition(vm, vm.propertyNames->toStringTagSymbol, jsString(&vm, "Object"), PropertyAttribute::DontEnum \| PropertyAttribute::ReadOnly);
93		~~didBecomePrototype();~~
94	93	}
95	94

trunk/Source/JavaScriptCore/runtime/IntlNumberFormatPrototype.cpp

r244708	r244713
89	89
90	90	putDirectWithoutTransition(vm, vm.propertyNames->toStringTagSymbol, jsString(&vm, "Object"), PropertyAttribute::DontEnum \| PropertyAttribute::ReadOnly);
91		~~didBecomePrototype();~~
92	91	}
93	92

trunk/Source/JavaScriptCore/runtime/IntlPluralRulesPrototype.cpp

r244708	r244713
76	76
77	77	putDirectWithoutTransition(vm, vm.propertyNames->toStringTagSymbol, jsString(&vm, "Object"), PropertyAttribute::DontEnum \| PropertyAttribute::ReadOnly);
78		~~didBecomePrototype();~~
79	78	}
80	79

trunk/Source/JavaScriptCore/runtime/JSArrayBufferPrototype.cpp

r244708	r244713
122	122	else
123	123	JSC_NATIVE_GETTER_WITHOUT_TRANSITION(vm.propertyNames->byteLength, sharedArrayBufferProtoGetterFuncByteLength, PropertyAttribute::DontEnum \| PropertyAttribute::ReadOnly);
124		~~didBecomePrototype();~~
125	124	}
126	125

trunk/Source/JavaScriptCore/runtime/JSDataViewPrototype.cpp

r244708	r244713
111	111	Base::finishCreation(vm);
112	112	putDirectWithoutTransition(vm, vm.propertyNames->toStringTagSymbol, jsString(&vm, "DataView"), PropertyAttribute::DontEnum \| PropertyAttribute::ReadOnly);
113		~~didBecomePrototype();~~
114	113	}
115	114

trunk/Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototypeInlines.h

r244708	r244713
46	46	putDirect(vm, vm.propertyNames->BYTES_PER_ELEMENT, jsNumber(ViewClass::elementSize), PropertyAttribute::DontEnum \| PropertyAttribute::ReadOnly \| PropertyAttribute::DontDelete);
47	47
48		~~didBecomePrototype();~~
49	48	}
50	49

trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp

r244708	r244713
233	233	{
234	234	JSGlobalObject* global = jsCast<JSGlobalObject*>(object);
235		JSValue prototype = constructEmptyObject(global->globalExec());
236		prototype.getObject()->didBecomePrototype();
237		return ConsoleObject::create(vm, global, ConsoleObject::createStructure(vm, global, prototype));
	235	return ConsoleObject::create(vm, global, ConsoleObject::createStructure(vm, global, constructEmptyObject(global->globalExec())));
238	236	}
239	237

trunk/Source/JavaScriptCore/runtime/JSPromisePrototype.cpp

r244708	r244713
78	78	Base::finishCreation(vm);
79	79	putDirectWithoutTransition(vm, vm.propertyNames->toStringTagSymbol, jsString(&vm, "Promise"), PropertyAttribute::DontEnum \| PropertyAttribute::ReadOnly);
80		~~didBecomePrototype();~~
81	80	}
82	81

trunk/Source/JavaScriptCore/runtime/JSTypedArrayViewConstructor.cpp

r244708	r244713
56	56	JSC_BUILTIN_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->of, typedArrayConstructorOfCodeGenerator, static_cast<unsigned>(PropertyAttribute::DontEnum));
57	57	JSC_BUILTIN_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->from, typedArrayConstructorFromCodeGenerator, static_cast<unsigned>(PropertyAttribute::DontEnum));
58
59		~~didBecomePrototype();~~
60	58	}
61	59

trunk/Source/JavaScriptCore/runtime/JSTypedArrayViewPrototype.cpp

r244708	r244713
335	335	putDirectWithoutTransition(vm, vm.propertyNames->iteratorSymbol, valuesFunction, static_cast<unsigned>(PropertyAttribute::DontEnum));
336	336
337		~~didBecomePrototype();~~
338	337	}
339	338

trunk/Source/JavaScriptCore/runtime/NumberPrototype.cpp

r244708	r244713
83	83	JSC_NATIVE_INTRINSIC_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->toString, numberProtoFuncToString, static_cast<unsigned>(PropertyAttribute::DontEnum), 1, NumberPrototypeToStringIntrinsic);
84	84	ASSERT(inherits(vm, info()));
85		~~didBecomePrototype();~~
86	85	}
87	86

trunk/Source/JavaScriptCore/runtime/RegExpPrototype.cpp

r244708	r244713
82	82	JSC_BUILTIN_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->splitSymbol, regExpPrototypeSplitCodeGenerator, static_cast<unsigned>(PropertyAttribute::DontEnum));
83	83	JSC_BUILTIN_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->test, regExpPrototypeTestCodeGenerator, static_cast<unsigned>(PropertyAttribute::DontEnum));
84
85		~~didBecomePrototype();~~
86	84	}
87	85

trunk/Source/JavaScriptCore/runtime/StringPrototype.cpp

r244708	r244713
173	173	// The constructor will be added later, after StringConstructor has been built
174	174	putDirectWithoutTransition(vm, vm.propertyNames->length, jsNumber(0), PropertyAttribute::DontDelete \| PropertyAttribute::ReadOnly \| PropertyAttribute::DontEnum);
175
176		~~didBecomePrototype();~~
177	175	}
178	176

trunk/Source/JavaScriptCore/runtime/Structure.cpp

r244708	r244713
322	322	}
323	323
324		~~bool Structure::isValidPrototype(JSValue prototype)~~
325		{
326		~~return prototype.isNull() \|\| (prototype.isObject() && prototype.getObject()->mayBePrototype());~~
327		}
328
329	324	void Structure::findStructuresAndMapForMaterialization(Vector<Structure, 8>& structures, Structure& structure, PropertyTable*& table)
330	325	{
…	…
550	545	Structure* Structure::changePrototypeTransition(VM& vm, Structure* structure, JSValue prototype, DeferredStructureTransitionWatchpointFire& deferred)
551	546	{
552		ASSERT(~~isValidPrototype(prototype~~));
	547	ASSERT(prototype.isObject() \|\| prototype.isNull());
553	548
554	549	DeferGC deferGC(vm.heap);

trunk/Source/JavaScriptCore/runtime/Structure.h

-                      r244708
+                      r244713
+    {
         Base::finishCreation(vm);
         ASSERT(m_prototype.get().isEmpty() || isValidPrototype(m_prototype.get()));
+        ASSERT(m_prototype.get().isEmpty() || m_prototype.isObject() || m_prototype.isNull());
+    }
 …
     void checkConsistency();
-    JS_EXPORT_PRIVATE static bool isValidPrototype(JSValue);
     // This may grab the lock, or not. Do not call when holding the Structure's lock.
     PropertyTable* ensurePropertyTableIfNotEmpty(VM& vm)

trunk/Source/JavaScriptCore/runtime/SymbolPrototype.cpp

r244708	r244713
68	68	JSFunction* toPrimitiveFunction = JSFunction::create(vm, globalObject, 1, "[Symbol.toPrimitive]"_s, symbolProtoFuncValueOf, NoIntrinsic);
69	69	putDirectWithoutTransition(vm, vm.propertyNames->toPrimitiveSymbol, toPrimitiveFunction, PropertyAttribute::DontEnum \| PropertyAttribute::ReadOnly);
70
71		~~didBecomePrototype();~~
72	70	}
73	71

trunk/Source/JavaScriptCore/wasm/js/WebAssemblyCompileErrorPrototype.cpp

r244708	r244713
58	58	{
59	59	Base::finishCreation(vm);
60		~~didBecomePrototype();~~
61	60	}
62	61

trunk/Source/JavaScriptCore/wasm/js/WebAssemblyInstancePrototype.cpp

r244708	r244713
87	87	{
88	88	Base::finishCreation(vm);
89		~~didBecomePrototype();~~
90	89	}
91	90

trunk/Source/JavaScriptCore/wasm/js/WebAssemblyLinkErrorPrototype.cpp

r244708	r244713
58	58	{
59	59	Base::finishCreation(vm);
60		~~didBecomePrototype();~~
61	60	}
62	61

trunk/Source/JavaScriptCore/wasm/js/WebAssemblyMemoryPrototype.cpp

r244708	r244713
110	110	Base::finishCreation(vm);
111	111	ASSERT(inherits(vm, info()));
112		~~didBecomePrototype();~~
113	112	}
114	113

trunk/Source/JavaScriptCore/wasm/js/WebAssemblyModulePrototype.cpp

r244708	r244713
57	57	{
58	58	Base::finishCreation(vm);
59		~~didBecomePrototype();~~
60	59	}
61	60

trunk/Source/JavaScriptCore/wasm/js/WebAssemblyPrototype.cpp

r244708	r244713
382	382	JSC_BUILTIN_FUNCTION_WITHOUT_TRANSITION("instantiateStreaming", webAssemblyPrototypeInstantiateStreamingCodeGenerator, static_cast<unsigned>(PropertyAttribute::DontEnum));
383	383	}
384
385		~~didBecomePrototype();~~
386	384	}
387	385

trunk/Source/JavaScriptCore/wasm/js/WebAssemblyRuntimeErrorPrototype.cpp

r244708	r244713
58	58	{
59	59	Base::finishCreation(vm);
60		~~didBecomePrototype();~~
61	60	}
62	61

trunk/Source/JavaScriptCore/wasm/js/WebAssemblyTablePrototype.cpp

r244708	r244713
165	165	Base::finishCreation(vm);
166	166	ASSERT(inherits(vm, info()));
167		~~didBecomePrototype();~~
168	167	}
169	168

trunk/Source/WebCore/ChangeLog

-                      r244708
+                      r244713
+-04-26  Commit Queue  <commit-queue@webkit.org>
+        Unreviewed, rolling out r244708.
+        https://bugs.webkit.org/show_bug.cgi?id=197334
+        "Broke the debug build" (Requested by rmorisset on #webkit).
+        Reverted changeset:
+        "All prototypes should call didBecomePrototype()"
+        https://bugs.webkit.org/show_bug.cgi?id=196315
+        https://trac.webkit.org/changeset/244708
 -04-26  Robin Morisset  <rmorisset@apple.com>

trunk/Source/WebCore/bindings/js/JSWindowProxy.cpp

r244708	r244713
98	98	// Perhaps the issue is that structure objects aren't seen when scanning the stack?
99	99	Strong<JSNonFinalObject> prototype(vm, isRemoteDOMWindow ? static_cast<JSNonFinalObject>(JSRemoteDOMWindowPrototype::create(vm, nullptr, &prototypeStructure)) : static_cast<JSNonFinalObject>(JSDOMWindowPrototype::create(vm, nullptr, &prototypeStructure)));
100		~~prototype->didBecomePrototype();~~
101	100
102	101	JSDOMGlobalObject* window = nullptr;

trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

-                      r244708
+                      r244713
     push(@$outputArray, "        : JSC::JSNonFinalObject(vm, structure)\n");
     push(@$outputArray, "    {\n");
-    push(@$outputArray, "        didBecomePrototype();\n");
     push(@$outputArray, "    }\n");
 …
     if (!$generatingNamedConstructor and $interface->parentType) {
         my $parentClassName = "JS" . $interface->parentType->name;
+        push(@$outputArray, "    auto result = ${parentClassName}::getConstructor(vm, &globalObject);\n");
+        push(@$outputArray, "    result.getObject()->didBecomePrototype();\n");
+        push(@$outputArray, "    return result;\n");
+        push(@$outputArray, "    return ${parentClassName}::getConstructor(vm, &globalObject);\n");
     } else {
         AddToImplIncludes("<JavaScriptCore/FunctionPrototype.h>");

trunk/Source/WebCore/bindings/scripts/test/JS/JSInterfaceName.cpp

r244708	r244713
63	63	: JSC::JSNonFinalObject(vm, structure)
64	64	{
65		~~didBecomePrototype();~~
66	65	}
67	66

trunk/Source/WebCore/bindings/scripts/test/JS/JSMapLike.cpp

r244708	r244713
82	82	: JSC::JSNonFinalObject(vm, structure)
83	83	{
84		~~didBecomePrototype();~~
85	84	}
86	85

trunk/Source/WebCore/bindings/scripts/test/JS/JSReadOnlyMapLike.cpp

r244708	r244713
79	79	: JSC::JSNonFinalObject(vm, structure)
80	80	{
81		~~didBecomePrototype();~~
82	81	}
83	82

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp

r244708	r244713
76	76	: JSC::JSNonFinalObject(vm, structure)
77	77	{
78		~~didBecomePrototype();~~
79	78	}
80	79

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCEReactions.cpp

r244708	r244713
88	88	: JSC::JSNonFinalObject(vm, structure)
89	89	{
90		~~didBecomePrototype();~~
91	90	}
92	91

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp

r244708	r244713
75	75	: JSC::JSNonFinalObject(vm, structure)
76	76	{
77		~~didBecomePrototype();~~
78	77	}
79	78

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCallTracer.cpp

r244708	r244713
93	93	: JSC::JSNonFinalObject(vm, structure)
94	94	{
95		~~didBecomePrototype();~~
96	95	}
97	96

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp

r244708	r244713
64	64	: JSC::JSNonFinalObject(vm, structure)
65	65	{
66		~~didBecomePrototype();~~
67	66	}
68	67

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.cpp

r244708	r244713
486	486	: JSC::JSNonFinalObject(vm, structure)
487	487	{
488		~~didBecomePrototype();~~
489	488	}
490	489
…	…
496	495	template<> JSValue JSTestDOMJITConstructor::prototypeForStructure(JSC::VM& vm, const JSDOMGlobalObject& globalObject)
497	496	{
498		auto result = JSNode::getConstructor(vm, &globalObject);
499		result.getObject()->didBecomePrototype();
500		return result;
	497	return JSNode::getConstructor(vm, &globalObject);
501	498	}
502	499

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.cpp

r244708	r244713
85	85	: JSC::JSNonFinalObject(vm, structure)
86	86	{
87		~~didBecomePrototype();~~
88	87	}
89	88

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp

r244708	r244713
145	145	: JSC::JSNonFinalObject(vm, structure)
146	146	{
147		~~didBecomePrototype();~~
148	147	}
149	148
…	…
172	171	template<> JSValue JSTestEventConstructorConstructor::prototypeForStructure(JSC::VM& vm, const JSDOMGlobalObject& globalObject)
173	172	{
174		auto result = JSEvent::getConstructor(vm, &globalObject);
175		result.getObject()->didBecomePrototype();
176		return result;
	173	return JSEvent::getConstructor(vm, &globalObject);
177	174	}
178	175

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp

r244708	r244713
73	73	: JSC::JSNonFinalObject(vm, structure)
74	74	{
75		~~didBecomePrototype();~~
76	75	}
77	76
…	…
83	82	template<> JSValue JSTestEventTargetConstructor::prototypeForStructure(JSC::VM& vm, const JSDOMGlobalObject& globalObject)
84	83	{
85		auto result = JSEventTarget::getConstructor(vm, &globalObject);
86		result.getObject()->didBecomePrototype();
87		return result;
	84	return JSEventTarget::getConstructor(vm, &globalObject);
88	85	}
89	86

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp

r244708	r244713
66	66	: JSC::JSNonFinalObject(vm, structure)
67	67	{
68		~~didBecomePrototype();~~
69	68	}
70	69

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp

r244708	r244713
66	66	: JSC::JSNonFinalObject(vm, structure)
67	67	{
68		~~didBecomePrototype();~~
69	68	}
70	69

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.h

r244708	r244713
103	103	: JSC::JSNonFinalObject(vm, structure)
104	104	{
105		~~didBecomePrototype();~~
106	105	}
107	106	public:

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp

r244708	r244713
65	65	: JSC::JSNonFinalObject(vm, structure)
66	66	{
67		~~didBecomePrototype();~~
68	67	}
69	68

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp

r244708	r244713
65	65	: JSC::JSNonFinalObject(vm, structure)
66	66	{
67		~~didBecomePrototype();~~
68	67	}
69	68

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp

r244708	r244713
71	71	: JSC::JSNonFinalObject(vm, structure)
72	72	{
73		~~didBecomePrototype();~~
74	73	}
75	74

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp

r244708	r244713
169	169	: JSC::JSNonFinalObject(vm, structure)
170	170	{
171		~~didBecomePrototype();~~
172	171	}
173	172

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp

r244708	r244713
66	66	: JSC::JSNonFinalObject(vm, structure)
67	67	{
68		~~didBecomePrototype();~~
69	68	}
70	69

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestIterable.cpp

r244708	r244713
74	74	: JSC::JSNonFinalObject(vm, structure)
75	75	{
76		~~didBecomePrototype();~~
77	76	}
78	77

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp

r244708	r244713
70	70	: JSC::JSNonFinalObject(vm, structure)
71	71	{
72		~~didBecomePrototype();~~
73	72	}
74	73

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp

r244708	r244713
71	71	: JSC::JSNonFinalObject(vm, structure)
72	72	{
73		~~didBecomePrototype();~~
74	73	}
75	74

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp

r244708	r244713
66	66	: JSC::JSNonFinalObject(vm, structure)
67	67	{
68		~~didBecomePrototype();~~
69	68	}
70	69

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp

r244708	r244713
66	66	: JSC::JSNonFinalObject(vm, structure)
67	67	{
68		~~didBecomePrototype();~~
69	68	}
70	69

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp

r244708	r244713
73	73	: JSC::JSNonFinalObject(vm, structure)
74	74	{
75		~~didBecomePrototype();~~
76	75	}
77	76

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp

r244708	r244713
66	66	: JSC::JSNonFinalObject(vm, structure)
67	67	{
68		~~didBecomePrototype();~~
69	68	}
70	69

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp

r244708	r244713
65	65	: JSC::JSNonFinalObject(vm, structure)
66	66	{
67		~~didBecomePrototype();~~
68	67	}
69	68

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp

r244708	r244713
65	65	: JSC::JSNonFinalObject(vm, structure)
66	66	{
67		~~didBecomePrototype();~~
68	67	}
69	68

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp

r244708	r244713
70	70	: JSC::JSNonFinalObject(vm, structure)
71	71	{
72		~~didBecomePrototype();~~
73	72	}
74	73

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp

r244708	r244713
66	66	: JSC::JSNonFinalObject(vm, structure)
67	67	{
68		~~didBecomePrototype();~~
69	68	}
70	69

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp

r244708	r244713
65	65	: JSC::JSNonFinalObject(vm, structure)
66	66	{
67		~~didBecomePrototype();~~
68	67	}
69	68

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp

r244708	r244713
65	65	: JSC::JSNonFinalObject(vm, structure)
66	66	{
67		~~didBecomePrototype();~~
68	67	}
69	68

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp

r244708	r244713
70	70	: JSC::JSNonFinalObject(vm, structure)
71	71	{
72		~~didBecomePrototype();~~
73	72	}
74	73

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp

r244708	r244713
65	65	: JSC::JSNonFinalObject(vm, structure)
66	66	{
67		~~didBecomePrototype();~~
68	67	}
69	68

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp

r244708	r244713
65	65	: JSC::JSNonFinalObject(vm, structure)
66	66	{
67		~~didBecomePrototype();~~
68	67	}
69	68

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp

r244708	r244713
70	70	: JSC::JSNonFinalObject(vm, structure)
71	71	{
72		~~didBecomePrototype();~~
73	72	}
74	73

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp

r244708	r244713
73	73	: JSC::JSNonFinalObject(vm, structure)
74	74	{
75		~~didBecomePrototype();~~
76	75	}
77	76

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp

r244708	r244713
73	73	: JSC::JSNonFinalObject(vm, structure)
74	74	{
75		~~didBecomePrototype();~~
76	75	}
77	76

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp

r244708	r244713
65	65	: JSC::JSNonFinalObject(vm, structure)
66	66	{
67		~~didBecomePrototype();~~
68	67	}
69	68

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp

r244708	r244713
72	72	: JSC::JSNonFinalObject(vm, structure)
73	73	{
74		~~didBecomePrototype();~~
75	74	}
76	75

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp

r244708	r244713
72	72	: JSC::JSNonFinalObject(vm, structure)
73	73	{
74		~~didBecomePrototype();~~
75	74	}
76	75

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp

r244708	r244713
89	89	: JSC::JSNonFinalObject(vm, structure)
90	90	{
91		~~didBecomePrototype();~~
92	91	}
93	92
…	…
110	109	template<> JSValue JSTestNodeConstructor::prototypeForStructure(JSC::VM& vm, const JSDOMGlobalObject& globalObject)
111	110	{
112		auto result = JSNode::getConstructor(vm, &globalObject);
113		result.getObject()->didBecomePrototype();
114		return result;
	111	return JSNode::getConstructor(vm, &globalObject);
115	112	}
116	113

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp

r244708	r244713
1820	1820	: JSC::JSNonFinalObject(vm, structure)
1821	1821	{
1822		~~didBecomePrototype();~~
1823	1822	}
1824	1823

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp

r244708	r244713
69	69	: JSC::JSNonFinalObject(vm, structure)
70	70	{
71		~~didBecomePrototype();~~
72	71	}
73	72

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp

r244708	r244713
68	68	: JSC::JSNonFinalObject(vm, structure)
69	69	{
70		~~didBecomePrototype();~~
71	70	}
72	71

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp

r244708	r244713
73	73	: JSC::JSNonFinalObject(vm, structure)
74	74	{
75		~~didBecomePrototype();~~
76	75	}
77	76

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestPluginInterface.cpp

r244708	r244713
64	64	: JSC::JSNonFinalObject(vm, structure)
65	65	{
66		~~didBecomePrototype();~~
67	66	}
68	67

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp

r244708	r244713
148	148	: JSC::JSNonFinalObject(vm, structure)
149	149	{
150		~~didBecomePrototype();~~
151	150	}
152	151
…	…
176	175	template<> JSValue JSTestPromiseRejectionEventConstructor::prototypeForStructure(JSC::VM& vm, const JSDOMGlobalObject& globalObject)
177	176	{
178		auto result = JSEvent::getConstructor(vm, &globalObject);
179		result.getObject()->didBecomePrototype();
180		return result;
	177	return JSEvent::getConstructor(vm, &globalObject);
181	178	}
182	179

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerialization.cpp

r244708	r244713
105	105	: JSC::JSNonFinalObject(vm, structure)
106	106	{
107		~~didBecomePrototype();~~
108	107	}
109	108

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.cpp

r244708	r244713
62	62	: JSC::JSNonFinalObject(vm, structure)
63	63	{
64		~~didBecomePrototype();~~
65	64	}
66	65
…	…
72	71	template<> JSValue JSTestSerializationIndirectInheritanceConstructor::prototypeForStructure(JSC::VM& vm, const JSDOMGlobalObject& globalObject)
73	72	{
74		auto result = JSTestSerializationInherit::getConstructor(vm, &globalObject);
75		result.getObject()->didBecomePrototype();
76		return result;
	73	return JSTestSerializationInherit::getConstructor(vm, &globalObject);
77	74	}
78	75

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializationInherit.cpp

r244708	r244713
72	72	: JSC::JSNonFinalObject(vm, structure)
73	73	{
74		~~didBecomePrototype();~~
75	74	}
76	75
…	…
82	81	template<> JSValue JSTestSerializationInheritConstructor::prototypeForStructure(JSC::VM& vm, const JSDOMGlobalObject& globalObject)
83	82	{
84		auto result = JSTestSerialization::getConstructor(vm, &globalObject);
85		result.getObject()->didBecomePrototype();
86		return result;
	83	return JSTestSerialization::getConstructor(vm, &globalObject);
87	84	}
88	85

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp

r244708	r244713
74	74	: JSC::JSNonFinalObject(vm, structure)
75	75	{
76		~~didBecomePrototype();~~
77	76	}
78	77
…	…
84	83	template<> JSValue JSTestSerializationInheritFinalConstructor::prototypeForStructure(JSC::VM& vm, const JSDOMGlobalObject& globalObject)
85	84	{
86		auto result = JSTestSerializationInherit::getConstructor(vm, &globalObject);
87		result.getObject()->didBecomePrototype();
88		return result;
	85	return JSTestSerializationInherit::getConstructor(vm, &globalObject);
89	86	}
90	87

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp

r244708	r244713
87	87	: JSC::JSNonFinalObject(vm, structure)
88	88	{
89		~~didBecomePrototype();~~
90	89	}
91	90

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStringifier.cpp

r244708	r244713
69	69	: JSC::JSNonFinalObject(vm, structure)
70	70	{
71		~~didBecomePrototype();~~
72	71	}
73	72

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp

r244708	r244713
69	69	: JSC::JSNonFinalObject(vm, structure)
70	70	{
71		~~didBecomePrototype();~~
72	71	}
73	72

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp

r244708	r244713
70	70	: JSC::JSNonFinalObject(vm, structure)
71	71	{
72		~~didBecomePrototype();~~
73	72	}
74	73

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp

r244708	r244713
70	70	: JSC::JSNonFinalObject(vm, structure)
71	71	{
72		~~didBecomePrototype();~~
73	72	}
74	73

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp

r244708	r244713
69	69	: JSC::JSNonFinalObject(vm, structure)
70	70	{
71		~~didBecomePrototype();~~
72	71	}
73	72

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp

r244708	r244713
71	71	: JSC::JSNonFinalObject(vm, structure)
72	72	{
73		~~didBecomePrototype();~~
74	73	}
75	74

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp

r244708	r244713
72	72	: JSC::JSNonFinalObject(vm, structure)
73	73	{
74		~~didBecomePrototype();~~
75	74	}
76	75

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp

r244708	r244713
115	115	: JSC::JSNonFinalObject(vm, structure)
116	116	{
117		~~didBecomePrototype();~~
118	117	}
119	118

Note: See TracChangeset for help on using the changeset viewer.

Context Navigation

Changeset 244713 in webkit

Legend:

Download in other formats: