Changeset 244722 in webkit


Ignore:
Timestamp:
Apr 27, 2019 12:31:00 PM (5 years ago)
Author:
Simon Fraser
Message:

Move some Compositing logging to the Layers log channel
https://bugs.webkit.org/show_bug.cgi?id=197345

Reviewed by Sam Weinig.

Make Compositing logging a bit less verbose by moving the GraphicsLayer tree dump
to the Layers log channel. Also log GraphicsLayers after flushing, when we'll have
accurate visible rects.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateCoverage):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::layersLogEnabled):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::updateCompositingLayers):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r244718 r244722  
     12019-04-27  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Move some Compositing logging to the Layers log channel
     4        https://bugs.webkit.org/show_bug.cgi?id=197345
     5
     6        Reviewed by Sam Weinig.
     7
     8        Make Compositing logging a bit less verbose by moving the GraphicsLayer tree dump
     9        to the Layers log channel. Also log GraphicsLayers after flushing, when we'll have
     10        accurate visible rects.
     11
     12        * platform/graphics/ca/GraphicsLayerCA.cpp:
     13        (WebCore::GraphicsLayerCA::updateCoverage):
     14        * rendering/RenderLayerCompositor.cpp:
     15        (WebCore::layersLogEnabled):
     16        (WebCore::RenderLayerCompositor::flushPendingLayerChanges):
     17        (WebCore::RenderLayerCompositor::updateCompositingLayers):
     18
    1192019-04-27  Megan Gardner  <megan_gardner@apple.com>
    220
  • trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp

    r243962 r244722  
    24242424                return "has transform animation with unknown extent";
    24252425            };
    2426             LOG_WITH_STREAM(Compositing, stream << "GraphicsLayerCA " << this << " id " << primaryLayerID() << " setBackingStoreAttached: " << requiresBacking << " (" << reasonForBacking() << ")");
     2426            LOG_WITH_STREAM(Layers, stream << "GraphicsLayerCA " << this << " id " << primaryLayerID() << " setBackingStoreAttached: " << requiresBacking << " (" << reasonForBacking() << ")");
    24272427        } else
    2428             LOG_WITH_STREAM(Compositing, stream << "GraphicsLayerCA " << this << " id " << primaryLayerID() << " setBackingStoreAttached: " << requiresBacking);
     2428            LOG_WITH_STREAM(Layers, stream << "GraphicsLayerCA " << this << " id " << primaryLayerID() << " setBackingStoreAttached: " << requiresBacking);
    24292429#endif
    24302430
  • trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

    r244612 r244722  
    277277    return LogCompositing.state == WTFLogChannelState::On;
    278278}
     279
     280static inline bool layersLogEnabled()
     281{
     282    return LogLayers.state == WTFLogChannelState::On;
     283}
    279284#endif
    280285
     
    493498    if (!isFlushRoot && rootLayerAttachment() == RootLayerAttachedViaEnclosingFrame)
    494499        return;
    495    
     500
    496501    if (rootLayerAttachment() == RootLayerUnattached) {
    497502#if PLATFORM(IOS_FAMILY)
     
    516521       
    517522        ASSERT(m_flushingLayers);
     523
     524#if ENABLE(TREE_DEBUGGING)
     525        if (layersLogEnabled()) {
     526            LOG(Layers, "RenderLayerCompositor::flushPendingLayerChanges");
     527            showGraphicsLayerTree(m_rootContentsLayer.get());
     528        }
     529#endif
    518530    }
    519531
     
    807819        LOG(Compositing, "RenderLayerCompositor::updateCompositingLayers - post");
    808820        showPaintOrderTree(m_renderView.layer());
    809         LOG(Compositing, "RenderLayerCompositor::updateCompositingLayers - GraphicsLayers post, contentLayersCount %d", m_contentLayersCount);
    810         showGraphicsLayerTree(m_rootContentsLayer.get());
    811821    }
    812822#endif
Note: See TracChangeset for help on using the changeset viewer.