Changeset 244761 in webkit

Timestamp:

Apr 29, 2019 3:40:48 PM (5 years ago)

Author:

Chris Dumez

Message:

[iOS] The UIProcess may get killed for trying to stay runnable in the background for more than 30 seconds
​https://bugs.webkit.org/show_bug.cgi?id=197385
<rdar://problem/50001505>

Reviewed by Geoffrey Garen.

If the UIProcess holds a background assertion for itself for 30 seconds, the assertion's invalidation handler
will get called and it is our responsibility to release this assertion or the UIProcess will get killed by the
system. The logic in ProcessAssertion would normally do that but it would also happily try and re-take another
background process assertion shortly after the previous one expired (and before the UIProcess got suspended).
When doing so, the new background assertion would expire right away and we would get killed without its
invalidation handler getting called.

To address the issue, the logic in ProcessAssertion will now prevent taking a new background assertion after
one expires and until the application becomes foreground again.

• UIProcess/ios/ProcessAssertionIOS.mm:

(-[WKProcessAssertionBackgroundTaskManager init]):
(-[WKProcessAssertionBackgroundTaskManager _updateBackgroundTask]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/ProcessAssertionIOS.mm (modified) (4 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-04-29  Chris Dumez  <cdumez@apple.com>
+
+        [iOS] The UIProcess may get killed for trying to stay runnable in the background for more than 30 seconds
+        https://bugs.webkit.org/show_bug.cgi?id=197385
+        <rdar://problem/50001505>
+
+        Reviewed by Geoffrey Garen.
+
+        If the UIProcess holds a background assertion for itself for 30 seconds, the assertion's invalidation handler
+        will get called and it is our responsibility to release this assertion or the UIProcess will get killed by the
+        system. The logic in ProcessAssertion would normally do that but it would also happily try and re-take another
+        background process assertion shortly after the previous one expired (and before the UIProcess got suspended).
+        When doing so, the new background assertion would expire right away and we would get killed without its
+        invalidation handler getting called.
+
+        To address the issue, the logic in ProcessAssertion will now prevent taking a new background assertion after
+        one expires and until the application becomes foreground again.
+
+        * UIProcess/ios/ProcessAssertionIOS.mm:
+        (-[WKProcessAssertionBackgroundTaskManager init]):
+        (-[WKProcessAssertionBackgroundTaskManager _updateBackgroundTask]):
+
 2019-04-29  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm

@@ -51 +51 @@
     UIBackgroundTaskIdentifier _backgroundTask;
     HashSet<ProcessAndUIAssertion*> _assertionsNeedingBackgroundTask;
+    BOOL _assertionHasExpiredInTheBackground;
 }
 
@@ -67 +68 @@
     _backgroundTask = UIBackgroundTaskInvalid;
 
+    [[NSNotificationCenter defaultCenter] addObserverForName:UIApplicationWillEnterForegroundNotification object:[UIApplication sharedApplication] queue:nil usingBlock:^(NSNotification *) {
+        _assertionHasExpiredInTheBackground = NO;
+        [self _updateBackgroundTask];
+    }];
+
     return self;
 }
@@ -99 +105 @@
 {
     if (!_assertionsNeedingBackgroundTask.isEmpty() && _backgroundTask == UIBackgroundTaskInvalid) {
+        if (_assertionHasExpiredInTheBackground) {
+            RELEASE_LOG_ERROR(ProcessSuspension, "%p - WKProcessAssertionBackgroundTaskManager: Ignored request to start a background task because we're still in the background and the previous task expired", self);
+            // Our invalidation handler would not get called if we tried to re-take a new background assertion at this point, and the UIProcess would get killed (rdar://problem/50001505).
+            return;
+        }
         RELEASE_LOG(ProcessSuspension, "%p - WKProcessAssertionBackgroundTaskManager - beginBackgroundTaskWithName", self);
         _backgroundTask = [[UIApplication sharedApplication] beginBackgroundTaskWithName:@"com.apple.WebKit.ProcessAssertion" expirationHandler:^{
@@ -110 +121 @@
                 });
             }
+
+            // Remember that the assertion has expired in the background so we do not try to re-take it until the application becomes foreground again.
+            _assertionHasExpiredInTheBackground = YES;
             [self _releaseBackgroundTask];
         }];