Changeset 244904 in webkit

Timestamp:

May 2, 2019 11:48:14 PM (5 years ago)

Author:

Antti Koivisto

Message:

Add a quirk to make gmail navigation bar scrollable without mouse hover on iOS
​https://bugs.webkit.org/show_bug.cgi?id=197529
<rdar://problem/49403416>

Reviewed by Simon Fraser.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::adjustRenderStyleForSiteSpecificQuirks):

Turn 'overflow:hidden' to 'overflow:auto' on element with role="navigation".
This should be both reasonably targeted and robust.

• css/StyleResolver.h:
• page/Quirks.cpp:

(WebCore::Quirks::needsGMailOverflowScrollQuirk const):

• page/Quirks.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/StyleResolver.cpp (modified) (2 diffs)
• css/StyleResolver.h (modified) (1 diff)
• page/Quirks.cpp (modified) (1 diff)
• page/Quirks.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-02  Antti Koivisto  <antti@apple.com>
+
+        Add a quirk to make gmail navigation bar scrollable without mouse hover on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=197529
+        <rdar://problem/49403416>
+
+        Reviewed by Simon Fraser.
+
+        * css/StyleResolver.cpp:
+        (WebCore::StyleResolver::adjustRenderStyle):
+        (WebCore::StyleResolver::adjustRenderStyleForSiteSpecificQuirks):
+
+        Turn 'overflow:hidden' to 'overflow:auto' on element with role="navigation".
+        This should be both reasonably targeted and robust.
+
+        * css/StyleResolver.h:
+        * page/Quirks.cpp:
+        (WebCore::Quirks::needsGMailOverflowScrollQuirk const):
+        * page/Quirks.h:
+
 2019-05-02  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/css/StyleResolver.cpp

@@ -77 +77 @@
 #include "PaintWorkletGlobalScope.h"
 #include "Pair.h"
+#include "Quirks.h"
 #include "RenderScrollbar.h"
 #include "RenderStyleConstants.h"
@@ -1122 +1123 @@
     style.setEffectiveTouchActions(computeEffectiveTouchActions(style, parentStyle.effectiveTouchActions()));
 #endif
+
+    if (element)
+        adjustRenderStyleForSiteSpecificQuirks(style, *element);
+}
+
+void StyleResolver::adjustRenderStyleForSiteSpecificQuirks(RenderStyle& style, const Element& element)
+{
+    if (document().quirks().needsGMailOverflowScrollQuirk()) {
+        // This turns sidebar scrollable without mouse move event.
+        if (style.overflowY() == Overflow::Hidden && element.attributeWithoutSynchronization(roleAttr) == "navigation")
+            style.setOverflowY(Overflow::Auto);
+    }
 }
 

trunk/Source/WebCore/css/StyleResolver.h

@@ -320 +320 @@
 
     void adjustRenderStyle(RenderStyle&, const RenderStyle& parentStyle, const RenderStyle* parentBoxStyle, const Element*);
+    void adjustRenderStyleForSiteSpecificQuirks(RenderStyle&, const Element&);
+
     std::unique_ptr<GridPosition> adjustNamedGridItemPosition(const NamedGridAreaMap&, const NamedGridLinesMap&, const GridPosition&, GridPositionSide) const;
     

trunk/Source/WebCore/page/Quirks.cpp

@@ -288 +288 @@
 }
 
-}
+bool Quirks::needsGMailOverflowScrollQuirk() const
+{
+#if PLATFORM(IOS_FAMILY)
+    if (!needsQuirks())
+        return false;
+
+    if (!m_needsGMailOverflowScrollQuirk)
+        m_needsGMailOverflowScrollQuirk = equalLettersIgnoringASCIICase(m_document->url().host(), "mail.google.com");
+
+    return *m_needsGMailOverflowScrollQuirk;
+#else
+    return false;
+#endif
+}
+
+
+}

trunk/Source/WebCore/page/Quirks.h

@@ -55 +55 @@
     WEBCORE_EXPORT bool isNeverRichlyEditableForTouchBar() const;
 
+    bool needsGMailOverflowScrollQuirk() const;
+
 private:
     bool needsQuirks() const;
@@ -62 +64 @@
     mutable Optional<bool> m_hasBrokenEncryptedMediaAPISupportQuirk;
     mutable Optional<bool> m_hasWebSQLSupportQuirk;
+#if PLATFORM(IOS_FAMILY)
+    mutable Optional<bool> m_needsGMailOverflowScrollQuirk;
+#endif
 };