Changeset 244930 in webkit

Timestamp:

May 3, 2019 3:06:57 PM (5 years ago)

Author:

aakash_jain@apple.com

Message:

New EWS: patches on recently added queues listed as #1 for older bugs
​https://bugs.webkit.org/show_bug.cgi?id=197496

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble._build_bubble):
(StatusBubble._queue_position):

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews/views/statusbubble.py (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py

@@ -63 +63 @@
             queue_position = self._queue_position(patch, queue, self._get_parent_queue(queue))
             bubble['queue_position'] = queue_position
+            if not queue_position:
+                return None
             bubble['details_message'] = 'Waiting in queue, processing has not started yet.\n\nPosition in queue: {}'.format(queue_position)
             return bubble
@@ -182 +184 @@
         from_timestamp = timezone.now() - datetime.timedelta(days=DAYS_TO_CHECK)
 
+        if patch.modified < from_timestamp:
+            # Do not display bubble for old patch for which no build has been reported on given queue.
+            # Most likely the patch would never be processed on this queue, since either the queue was
+            # added after the patch was submitted, or build request for that patch was cancelled.
+            return None
+
         previously_sent_patches = set(Patch.objects
                                           .filter(modified__gte=from_timestamp)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-05-03  Aakash Jain  <aakash_jain@apple.com>
+
+        New EWS: patches on recently added queues listed as #1 for older bugs
+        https://bugs.webkit.org/show_bug.cgi?id=197496
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+        (StatusBubble._build_bubble):
+        (StatusBubble._queue_position):
+
 2019-05-03  Aakash Jain  <aakash_jain@apple.com>