Changeset 244940 in webkit


Ignore:
Timestamp:
May 3, 2019 5:17:25 PM (5 years ago)
Author:
aakash_jain@apple.com
Message:

New EWS: Clicking on white bubble navigates to page with only bubbles
​https://bugs.webkit.org/show_bug.cgi?id=197520

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/ews-app/ews/templates/statusbubble.html

    r244485 r244940  
    7878  {% for bubble in bubbles %}
    7979  <a class="status {{ bubble.state }}" target="_top"
     80  {% if bubble.url %}
    8081      href="{{ bubble.url }}"
     82  {% endif %}
    8183  {% if bubble.details_message %}
    8284      title="{{ bubble.details_message }}"

  • trunk/Tools/ChangeLog

    r244934 r244940  
     12019-05-03  Aakash Jain  <aakash_jain@apple.com>
     2
     3        New EWS: Clicking on white bubble navigates to page with only bubbles
     4        https://bugs.webkit.org/show_bug.cgi?id=197520
     5
     6        Reviewed by Lucas Forschler.
     7
     8        * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
     9
    1102019-05-03  Daniel Bates  <dabates@apple.com>
    211
Note: See TracChangeset for help on using the changeset viewer.