Changeset 244949 in webkit

Timestamp:

May 4, 2019 10:51:12 AM (5 years ago)

Author:

youenn@apple.com

Message:

Convert some RealtimeOutgoingVideoSourceCocoa logging to ERROR_LOG
​https://bugs.webkit.org/show_bug.cgi?id=197549

Reviewed by Eric Carlson.

No change of behavior.

• platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:

(WebCore::RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-04  Youenn Fablet  <youenn@apple.com>
+
+        Convert some RealtimeOutgoingVideoSourceCocoa logging to ERROR_LOG
+        https://bugs.webkit.org/show_bug.cgi?id=197549
+
+        Reviewed by Eric Carlson.
+
+        No change of behavior.
+
+        * platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:
+        (WebCore::RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer):
+
 2019-05-03  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm

@@ -76 +76 @@
         auto status = VTImageRotationSessionCreate(kCFAllocatorDefault, rotation, &rawRotationSession);
         if (status != noErr) {
-            ALWAYS_LOG(LOGIDENTIFIER, "Failed creating a rotation session with error ", status);
+            ERROR_LOG(LOGIDENTIFIER, "Failed creating a rotation session with error ", status);
             return nullptr;
         }
@@ -101 +101 @@
 
         if (status != kCVReturnSuccess) {
-            ALWAYS_LOG(LOGIDENTIFIER, "Failed creating a pixel buffer pool with error ", status);
+            ERROR_LOG(LOGIDENTIFIER, "Failed creating a pixel buffer pool with error ", status);
             return nullptr;
         }
@@ -115 +115 @@
 
     if (status != kCVReturnSuccess) {
-        ALWAYS_LOG(LOGIDENTIFIER, "Failed creating a pixel buffer with error ", status);
+        ERROR_LOG(LOGIDENTIFIER, "Failed creating a pixel buffer with error ", status);
         return nullptr;
     }
@@ -123 +123 @@
 
     if (status != noErr) {
-        ALWAYS_LOG(LOGIDENTIFIER, "Failed rotating with error ", status);
+        ERROR_LOG(LOGIDENTIFIER, "Failed rotating with error ", status, " for rotation ", m_currentRotation);
         return nullptr;
     }