Changeset 244973 in webkit

Timestamp:

May 6, 2019 1:36:40 PM (5 years ago)

Author:

sbarati@apple.com

Message:

JS2 should print scores for different categories
​https://bugs.webkit.org/show_bug.cgi?id=197605

Reviewed by Yusuke Suzuki.

• JetStream2/JetStreamDriver.js:

(displayCategoryScores):
(isInBrowser.document.onkeydown):
(Driver.prototype.async.start):
(Driver.prototype.async.reportScoreToRunBenchmarkRunner):

Location:

trunk/PerformanceTests

Files:

• ChangeLog (modified) (1 diff)
• JetStream2/JetStreamDriver.js (modified) (4 diffs)

trunk/PerformanceTests/ChangeLog

@@ +1 @@
+2019-05-06  Saam Barati  <sbarati@apple.com>
+
+        JS2 should print scores for different categories
+        https://bugs.webkit.org/show_bug.cgi?id=197605
+
+        Reviewed by Yusuke Suzuki.
+
+        * JetStream2/JetStreamDriver.js:
+        (displayCategoryScores):
+        (isInBrowser.document.onkeydown):
+        (Driver.prototype.async.start):
+        (Driver.prototype.async.reportScoreToRunBenchmarkRunner):
+
 2019-04-16  Jon Lee  <jonlee@apple.com>
 

trunk/PerformanceTests/JetStream2/JetStreamDriver.js

@@ -42 +42 @@
 const defaultWorstCaseCount = 4;
 
+let showScoreDetails = false;
+let categoryScores = null;
+
+function displayCategoryScores() {
+    if (!categoryScores)
+        return;
+
+    let summaryElement = document.getElementById("result-summary");
+    for (let [category, scores] of categoryScores)
+        summaryElement.innerHTML += `<p> ${category}: ${uiFriendlyNumber(geomean(scores))}</p>`
+
+    categoryScores = null;
+}
+
+if (isInBrowser) {
+    document.onkeydown = (keyboardEvent) => {
+        let key = keyboardEvent.key;
+        if (key === "d" || key === "D") {
+            showScoreDetails = true;
+
+            displayCategoryScores();
+        }
+    };
+}
+
 function assert(b, m = "") {
     if (!b)
@@ -175 +200 @@
 
             try {
-
                 await benchmark.run();
             } catch(e) {
@@ -198 +222 @@
             allScores.push(benchmark.score);
 
+        categoryScores = new Map;
+        for (let benchmark of this.benchmarks) {
+            for (let category of Object.keys(benchmark.subTimes()))
+                categoryScores.set(category, []);
+        }
+
+        for (let benchmark of this.benchmarks) {
+            for (let [category, value] of Object.entries(benchmark.subTimes())) {
+                let arr = categoryScores.get(category);
+                arr.push(value);
+            }
+        }
+
         if (isInBrowser) {
             summaryElement.classList.add('done');
             summaryElement.innerHTML = "<div class=\"score\">" + uiFriendlyNumber(geomean(allScores)) + "</div><label>Score</label>";
+            summaryElement.onclick = displayCategoryScores;
+            if (showScoreDetails)
+                displayCategoryScores();
             statusElement.innerHTML = '';
-        } else
+        } else {
+            console.log("\n");
+            for (let [category, scores] of categoryScores)
+                console.log(`${category}: ${uiFriendlyNumber(geomean(scores))}`);
+
             console.log("\nTotal Score: ", uiFriendlyNumber(geomean(allScores)), "\n");
+        }
 
         this.reportScoreToRunBenchmarkRunner();
@@ -332 +377 @@
                 },
                 "tests": subResults,
-            };;
+            };
         }