Changeset 244986 in webkit

Timestamp:

May 6, 2019 4:10:36 PM (5 years ago)

Author:

Basuke Suzuki

Message:

[PlayStation] Fix build break since r244919
​https://bugs.webkit.org/show_bug.cgi?id=197627

Reviewed by Ross Kirsling.

Bugfix for POSIX socket implementation and suppress warnings.

• inspector/remote/socket/RemoteInspectorConnectionClient.h:

(Inspector::RemoteInspectorConnectionClient::didAccept):

• inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp:

(Inspector::Socket::getPort):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/remote/socket/RemoteInspectorConnectionClient.cpp (modified) (1 diff)
• inspector/remote/socket/RemoteInspectorConnectionClient.h (modified) (1 diff)
• inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-05-06  Basuke Suzuki  <Basuke.Suzuki@sony.com>
+
+        [PlayStation] Fix build break since r244919
+        https://bugs.webkit.org/show_bug.cgi?id=197627
+
+        Reviewed by Ross Kirsling.
+
+        Bugfix for POSIX socket implementation and suppress warnings.
+
+        * inspector/remote/socket/RemoteInspectorConnectionClient.h:
+        (Inspector::RemoteInspectorConnectionClient::didAccept):
+        * inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp:
+        (Inspector::Socket::getPort):
+
 2019-05-06  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorConnectionClient.cpp

@@ -81 +81 @@
 }
 
+void RemoteInspectorConnectionClient::didAccept(ConnectionID, ConnectionID, Socket::Domain)
+{
+}
+
 } // namespace Inspector
 

trunk/Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorConnectionClient.h

@@ -38 +38 @@
 public:
     void didReceiveWebInspectorEvent(ConnectionID, Vector<uint8_t>&&);
-    virtual void didAccept(ConnectionID acceptedID, ConnectionID listenerID, Socket::Domain) { };
+    virtual void didAccept(ConnectionID acceptedID, ConnectionID listenerID, Socket::Domain);
     virtual void didClose(ConnectionID) = 0;
 

trunk/Source/JavaScriptCore/inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp

@@ -168 +168 @@
 
     struct sockaddr_in address = { };
-    int len = sizeof(address);
+    socklen_t len = sizeof(address);
     getsockname(socket, reinterpret_cast<struct sockaddr*>(&address), &len);
     return address.sin_port;