Changeset 245007 in webkit


Ignore:
Timestamp:
May 7, 2019 5:33:56 AM (5 years ago)
Author:
Carlos Garcia Campos
Message:

[GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
https://bugs.webkit.org/show_bug.cgi?id=197651

Reviewed by Žan Doberšek.

This is required since the process creation was delayed until something is loaded in the view.

  • MiniBrowser/gtk/BrowserWindow.c:

(browser_window_get_or_create_web_view_for_automation):

  • MiniBrowser/wpe/main.cpp:

(main):

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r244998 r245007  
     12019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
     4        https://bugs.webkit.org/show_bug.cgi?id=197651
     5
     6        Reviewed by Žan Doberšek.
     7
     8        This is required since the process creation was delayed until something is loaded in the view.
     9
     10        * MiniBrowser/gtk/BrowserWindow.c:
     11        (browser_window_get_or_create_web_view_for_automation):
     12        * MiniBrowser/wpe/main.cpp:
     13        (main):
     14
    1152019-05-06  Tim Horton  <timothy_horton@apple.com>
    216
  • trunk/Tools/MiniBrowser/gtk/BrowserWindow.c

    r244583 r245007  
    12321232    BrowserWindow *window = (BrowserWindow *)windowList->data;
    12331233    WebKitWebView *webView = browser_tab_get_web_view(window->activeTab);
    1234     if (gtk_notebook_get_n_pages(GTK_NOTEBOOK(window->notebook)) == 1 && !webkit_web_view_get_uri(webView))
     1234    if (gtk_notebook_get_n_pages(GTK_NOTEBOOK(window->notebook)) == 1 && !webkit_web_view_get_uri(webView)) {
     1235        webkit_web_view_load_uri(webView, "about:blank");
    12351236        return webView;
     1237    }
    12361238
    12371239    WebKitWebView *newWebView = WEBKIT_WEB_VIEW(g_object_new(WEBKIT_TYPE_WEB_VIEW,
     
    12421244        NULL));
    12431245    browser_window_append_view(window, newWebView);
     1246    webkit_web_view_load_uri(newWebView, "about:blank");
    12441247    gtk_widget_grab_focus(GTK_WIDGET(newWebView));
    12451248    return newWebView;
  • trunk/Tools/MiniBrowser/wpe/main.cpp

    r242082 r245007  
    267267        webkit_web_view_load_uri(webView, url);
    268268        g_free(url);
    269     } else if (!automationMode)
     269    } else if (automationMode)
     270        webkit_web_view_load_uri(webView, "about:blank");
     271    else
    270272        webkit_web_view_load_uri(webView, "https://wpewebkit.org");
    271273
Note: See TracChangeset for help on using the changeset viewer.