Changeset 245016 in webkit


Ignore:
Timestamp:
May 7, 2019 10:37:16 AM (5 years ago)
Author:
Antti Koivisto
Message:

<body> with overflow:hidden shouldn't be keyboard scrollable on iOS
​https://bugs.webkit.org/show_bug.cgi?id=197659
Source/WebKit:

<rdar://problem/50541453>

Reviewed by Antoine Quint.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView isScrollableForKeyboardScrollViewAnimator:]):

Disable also keyboard scrolling when touch scrolling is disabled.

LayoutTests:

Reviewed by Antoine Quint.

  • fast/scrolling/ios/body-overflow-hidden-keyboard-expected.html: Added.
  • fast/scrolling/ios/body-overflow-hidden-keyboard.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r245013 r245016  
     12019-05-07  Antti Koivisto  <antti@apple.com>
     2
     3        <body> with overflow:hidden shouldn't be keyboard scrollable on iOS
     4        https://bugs.webkit.org/show_bug.cgi?id=197659
     5
     6        Reviewed by Antoine Quint.
     7
     8        * fast/scrolling/ios/body-overflow-hidden-keyboard-expected.html: Added.
     9        * fast/scrolling/ios/body-overflow-hidden-keyboard.html: Added.
     10
    1112019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
    212

  • trunk/Source/WebKit/ChangeLog

    r245009 r245016  
     12019-05-07  Antti Koivisto  <antti@apple.com>
     2
     3        <body> with overflow:hidden shouldn't be keyboard scrollable on iOS
     4        https://bugs.webkit.org/show_bug.cgi?id=197659
     5        <rdar://problem/50541453>
     6
     7        Reviewed by Antoine Quint.
     8
     9        * UIProcess/ios/WKContentViewInteraction.mm:
     10        (-[WKContentView isScrollableForKeyboardScrollViewAnimator:]):
     11
     12        Disable also keyboard scrolling when touch scrolling is disabled.
     13
    1142019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
    215

  • trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

    r244975 r245016  
    46214621        return NO;
    46224622
     4623    if (!_webView.scrollView.scrollEnabled)
     4624        return NO;
     4625
    46234626    return YES;
    46244627}
Note: See TracChangeset for help on using the changeset viewer.