Changeset 245030 in webkit

Timestamp:

May 7, 2019 1:46:43 PM (5 years ago)

Author:

rmorisset@apple.com

Message:

WTF::BitVector should have an isEmpty() method
​https://bugs.webkit.org/show_bug.cgi?id=197637

Reviewed by Keith Miller.

Source/JavaScriptCore:

Just replaces some comparison of bitCount() to 0 by calls to isEmpty()

• b3/air/AirAllocateRegistersByGraphColoring.cpp:

Source/WTF:

• wtf/BitVector.cpp:

(WTF::BitVector::isEmptySlow const):

• wtf/BitVector.h:

(WTF::BitVector::isEmpty const):

Location:

trunk/Source

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp (modified) (5 diffs)
• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/BitVector.cpp (modified) (1 diff)
• WTF/wtf/BitVector.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-05-07  Robin Morisset  <rmorisset@apple.com>
+
+        WTF::BitVector should have an isEmpty() method
+        https://bugs.webkit.org/show_bug.cgi?id=197637
+
+        Reviewed by Keith Miller.
+
+        Just replaces some comparison of bitCount() to 0 by calls to isEmpty()
+
+        * b3/air/AirAllocateRegistersByGraphColoring.cpp:
+
 2019-05-07  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp

@@ -325 +325 @@
     {
         ASSERT(m_simplifyWorklist.isEmpty());
-        ASSERT(!m_spillWorklist.bitCount());
+        ASSERT(m_spillWorklist.isEmpty());
 
         // Reclaim as much memory as possible.
@@ -670 +670 @@
             }
 
-            if (m_spillWorklist.bitCount()) {
+            if (!m_spillWorklist.isEmpty()) {
                 selectSpill();
                 changed = true;
@@ -679 +679 @@
         if (!ASSERT_DISABLED) {
             ASSERT(!m_simplifyWorklist.size());
-            ASSERT(!m_spillWorklist.bitCount());
+            ASSERT(m_spillWorklist.isEmpty());
             IndexType firstNonRegIndex = m_lastPrecoloredRegisterIndex + 1;
             for (IndexType i = firstNonRegIndex; i < m_degrees.size(); ++i)
@@ -993 +993 @@
             else if (!m_freezeWorklist.isEmpty())
                 freeze();
-            else if (m_spillWorklist.bitCount())
+            else if (!m_spillWorklist.isEmpty())
                 selectSpill();
 
@@ -1000 +1000 @@
                 dumpWorkLists(WTF::dataFile());
             }
-        } while (!m_simplifyWorklist.isEmpty() || !m_worklistMoves.isEmpty() || !m_freezeWorklist.isEmpty() || m_spillWorklist.bitCount());
+        } while (!m_simplifyWorklist.isEmpty() || !m_worklistMoves.isEmpty() || !m_freezeWorklist.isEmpty() || !m_spillWorklist.isEmpty());
 
         assignColors();

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2019-05-07  Robin Morisset  <rmorisset@apple.com>
+
+        WTF::BitVector should have an isEmpty() method
+        https://bugs.webkit.org/show_bug.cgi?id=197637
+
+        Reviewed by Keith Miller.
+
+        * wtf/BitVector.cpp:
+        (WTF::BitVector::isEmptySlow const):
+        * wtf/BitVector.h:
+        (WTF::BitVector::isEmpty const):
+
 2019-05-07  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WTF/wtf/BitVector.cpp

@@ -182 +182 @@
 }
 
+bool BitVector::isEmptySlow() const
+{
+    ASSERT(!isInline());
+    const OutOfLineBits* bits = outOfLineBits();
+    for (unsigned i = bits->numWords(); i--;) {
+        if (bits->bits()[i])
+            return false;
+    }
+    return true;
+}
+
 bool BitVector::equalsSlowCase(const BitVector& other) const
 {

trunk/Source/WTF/wtf/BitVector.h

@@ -236 +236 @@
         return bitCountSlow();
     }
+
+    bool isEmpty() const
+    {
+        if (isInline())
+            return !cleanseInlineBits(m_bitsOrPointer);
+        return isEmptySlow();
+    }
     
     size_t findBit(size_t index, bool value) const
@@ -454 +461 @@
     
     WTF_EXPORT_PRIVATE size_t bitCountSlow() const;
+    WTF_EXPORT_PRIVATE bool isEmptySlow() const;
     
     WTF_EXPORT_PRIVATE bool equalsSlowCase(const BitVector& other) const;