Changeset 245034 in webkit

Timestamp:

May 7, 2019 2:09:54 PM (5 years ago)

Author:

youenn@apple.com

Message:

Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
​https://bugs.webkit.org/show_bug.cgi?id=195997
<rdar://problem/50509884>

Reviewed by Chris Dumez.

Spin test until successful.

• TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-05-07  Youenn Fablet  <youenn@apple.com>
+
+        Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
+        https://bugs.webkit.org/show_bug.cgi?id=195997
+        <rdar://problem/50509884>
+
+        Reviewed by Chris Dumez.
+
+        Spin test until successful.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
+
 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm

@@ -1397 +1397 @@
     TestWebKitAPI::Util::run(&done);
     done = false;
-    EXPECT_TRUE([[configuration websiteDataStore] _hasRegisteredServiceWorker]);
+    while (![[configuration websiteDataStore] _hasRegisteredServiceWorker])
+        TestWebKitAPI::Util::spinRunLoop(0.1);
 
     webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);