Changeset 245096 in webkit

Timestamp:

May 8, 2019 11:37:11 PM (5 years ago)

Author:

zandobersek@gmail.com

Message:

[GLib] Rework WPE RunLoopSourcePriority values
​https://bugs.webkit.org/show_bug.cgi?id=197167

Reviewed by Carlos Garcia Campos.

The GLib priorities for the WPE port were initially aligned on the -70
value, theory being that this would help avoid any default-priority
GSources spawned in different dependency libraries affecting our
scheduling. Today it seems that extra caution might not be really
necessary.

This change aligns the base priority value with GLib's default priority
value of 0. We maintain the relativity of priority values by effectively
increasing each priority by 70.

• wtf/glib/RunLoopSourcePriority.h:

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/glib/RunLoopSourcePriority.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2019-05-08  Zan Dobersek  <zdobersek@igalia.com>
+
+        [GLib] Rework WPE RunLoopSourcePriority values
+        https://bugs.webkit.org/show_bug.cgi?id=197167
+
+        Reviewed by Carlos Garcia Campos.
+
+        The GLib priorities for the WPE port were initially aligned on the -70
+        value, theory being that this would help avoid any default-priority
+        GSources spawned in different dependency libraries affecting our
+        scheduling. Today it seems that extra caution might not be really
+        necessary.
+
+        This change aligns the base priority value with GLib's default priority
+        value of 0. We maintain the relativity of priority values by effectively
+        increasing each priority by 70.
+
+        * wtf/glib/RunLoopSourcePriority.h:
+
 2019-05-08  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WTF/wtf/glib/RunLoopSourcePriority.h

@@ -86 +86 @@
 
 enum RunLoopSourcePriority {
-    RunLoopDispatcher = -70,
-    RunLoopTimer = -70,
+    RunLoopDispatcher = 0,
+    RunLoopTimer = 0,
 
-    MainThreadDispatcherTimer = -60,
+    MainThreadDispatcherTimer = 10,
 
-    MemoryPressureHandlerTimer = -80,
+    MemoryPressureHandlerTimer = -10,
 
-    JavascriptTimer = -60,
-    MainThreadSharedTimer = -60,
+    JavascriptTimer = 10,
+    MainThreadSharedTimer = 10,
 
-    LayerFlushTimer = -70,
-    DisplayRefreshMonitorTimer = -70,
+    LayerFlushTimer = 0,
+    DisplayRefreshMonitorTimer = 0,
 
-    CompositingThreadUpdateTimer = -70,
+    CompositingThreadUpdateTimer = 0,
 
-    ReleaseUnusedResourcesTimer = -70,
+    ReleaseUnusedResourcesTimer = 0,
 
-    AsyncIONetwork = -60,
-    DiskCacheRead = -60,
-    DiskCacheWrite = -50
+    AsyncIONetwork = 10,
+    DiskCacheRead = 10,
+    DiskCacheWrite = 20
 };