Changeset 245136 in webkit

Timestamp:

May 9, 2019 9:09:35 AM (5 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-app] Production and Development env should configure DEBUG appropriately
​https://bugs.webkit.org/show_bug.cgi?id=197700

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-app/ews-app/settings.py:

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-app/ews-app/settings.py (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-app/ews-app/settings.py

@@ -34 +34 @@
 import os
 
+is_test_mode_enabled = os.getenv('EWS_PRODUCTION') is None
+
 # Build paths inside the project like this: os.path.join(BASE_DIR, ...)
 BASE_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
@@ -44 +46 @@
 SECRET_KEY = os.environ.get('EWS_SECRET_KEY', 'secret')
 
-# SECURITY WARNING: don't run with debug turned on in production!
-DEBUG = True
+DEBUG = False
+if is_test_mode_enabled:
+    # SECURITY WARNING: don't run with debug turned on in production!
+    DEBUG = True
 
 ALLOWED_HOSTS = ['*']
@@ -96 +100 @@
 # https://docs.djangoproject.com/en/1.11/ref/settings/#databases
 
-is_test_mode_enabled = os.getenv('EWS_PRODUCTION') is None
 if is_test_mode_enabled:
     DATABASES = {

trunk/Tools/ChangeLog

@@ +1 @@
+2019-05-09  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Production and Development env should configure DEBUG appropriately
+        https://bugs.webkit.org/show_bug.cgi?id=197700
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-app/ews-app/settings.py:
+
 2019-05-09  Xan López  <xan@igalia.com>