Changeset 245162 in webkit
- Timestamp:
- May 9, 2019 4:04:40 PM (5 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r245161 r245162 1 2019-05-09 Daniel Bates <dabates@apple.com> 2 3 [iOS] Right command key has wrong value for property code 4 https://bugs.webkit.org/show_bug.cgi?id=193876 5 <rdar://problem/47577308> 6 7 Reviewed by Brent Fulgham. 8 9 Update test result. 10 11 * fast/events/ios/keydown-keyup-special-keys-in-non-editable-element-expected.txt: 12 1 13 2019-05-09 Daniel Bates <dabates@apple.com> 2 14 -
trunk/LayoutTests/fast/events/ios/keydown-keyup-special-keys-in-non-editable-element-expected.txt
r245161 r245162 39 39 type: keydown, key: Alt, code: Unidentified, keyIdentifier: Alt, keyCode: 18, charCode: 0, keyCode: 18, which: 18 40 40 type: keyup, key: Alt, code: Unidentified, keyIdentifier: Alt, keyCode: 18, charCode: 0, keyCode: 18, which: 18 41 type: keydown, key: Meta, code: Unidentified, keyIdentifier: Meta, keyCode: 93, charCode: 0, keyCode: 93, which: 9342 type: keyup, key: Meta, code: Unidentified, keyIdentifier: Meta, keyCode: 93, charCode: 0, keyCode: 93, which: 9341 type: keydown, key: Meta, code: MetaRight, keyIdentifier: Meta, keyCode: 93, charCode: 0, keyCode: 93, which: 93 42 type: keyup, key: Meta, code: MetaRight, keyIdentifier: Meta, keyCode: 93, charCode: 0, keyCode: 93, which: 93 43 43 type: keydown, key: Control, code: ControlRight, keyIdentifier: Control, keyCode: 17, charCode: 0, keyCode: 17, which: 17 44 44 type: keyup, key: Control, code: ControlRight, keyIdentifier: Control, keyCode: 17, charCode: 0, keyCode: 17, which: 17 -
trunk/Source/WebCore/ChangeLog
r245161 r245162 1 2019-05-09 Daniel Bates <dabates@apple.com> 2 3 [iOS] Right command key has wrong value for property code 4 https://bugs.webkit.org/show_bug.cgi?id=193876 5 <rdar://problem/47577308> 6 7 Reviewed by Brent Fulgham. 8 9 We're looking for the wrong Windows virtual key code for the right command key. 10 Substitute VK_APPS for VK_RWIN so we can identify the right command key and return 11 the correct value for the code property of the DOM key event. 12 13 * platform/ios/PlatformEventFactoryIOS.mm: 14 (WebCore::codeForKeyEvent): 15 1 16 2019-05-09 Daniel Bates <dabates@apple.com> 2 17 -
trunk/Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm
r245161 r245162 276 276 case VK_RETURN: return "Enter"_s; // Labeled Return on Apple keyboards. 277 277 case VK_LWIN: return "MetaLeft"_s; 278 case VK_ RWIN: return "MetaRight"_s;278 case VK_APPS: return "MetaRight"_s; 279 279 case VK_LSHIFT: return "ShiftLeft"_s; 280 280 case VK_RSHIFT: return "ShiftRight"_s;
Note: See TracChangeset
for help on using the changeset viewer.