Changeset 245167 in webkit

Timestamp:

May 9, 2019 5:32:09 PM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Uncaught Exception: null is not an object (evaluating 'resource.parentFrame.securityOrigin')
​https://bugs.webkit.org/show_bug.cgi?id=196572
<rdar://problem/49578338>

Reviewed by Timothy Hatcher.

• UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel.prototype._addResource):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/SourcesNavigationSidebarPanel.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-05-09  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Uncaught Exception: null is not an object (evaluating 'resource.parentFrame.securityOrigin')
+        https://bugs.webkit.org/show_bug.cgi?id=196572
+        <rdar://problem/49578338>
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/SourcesNavigationSidebarPanel.js:
+        (WI.SourcesNavigationSidebarPanel.prototype._addResource):
+
 2019-05-09  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js

@@ -669 +669 @@
                 if (resource.urlComponents.port)
                     origin += ":" + resource.urlComponents.port;
-            } else
+            } else if (resource.parentFrame)
                 origin = resource.parentFrame.securityOrigin;
 
-            let frameTreeElement = this._originTreeElementMap.get(origin);
-            if (!frameTreeElement) {
-                frameTreeElement = new WI.FolderTreeElement(origin, origin === resource.parentFrame.securityOrigin ? resource.parentFrame : null);
-                this._originTreeElementMap.set(origin, frameTreeElement);
-
-                let index = insertionIndexForObjectInListSortedByFunction(frameTreeElement, this._resourcesTreeOutline.children, this._boundCompareTreeElements);
-                this._resourcesTreeOutline.insertChild(frameTreeElement, index);
+            let parentTreeElement = null;
+            if (origin) {
+                let frameTreeElement = this._originTreeElementMap.get(origin);
+                if (!frameTreeElement) {
+                    frameTreeElement = new WI.FolderTreeElement(origin, origin === resource.parentFrame.securityOrigin ? resource.parentFrame : null);
+                    this._originTreeElementMap.set(origin, frameTreeElement);
+
+                    let index = insertionIndexForObjectInListSortedByFunction(frameTreeElement, this._resourcesTreeOutline.children, this._boundCompareTreeElements);
+                    this._resourcesTreeOutline.insertChild(frameTreeElement, index);
+                }
+
+                let subpath = resource.urlComponents.path;
+                if (subpath && subpath[0] === "/")
+                    subpath = subpath.substring(1);
+
+                parentTreeElement = frameTreeElement.createFoldersAsNeededForSubpath(subpath);
+            } else {
+                parentTreeElement = this._resourcesTreeOutline;
             }
 
@@ -687 +698 @@
                 resourceTreeElement = new WI.ResourceTreeElement(resource, resource, {allowDirectoryAsName: true, hideOrigin: true});
 
-            let subpath = resource.urlComponents.path;
-            if (subpath && subpath[0] === "/")
-                subpath = subpath.substring(1);
-
-            let parent = frameTreeElement.createFoldersAsNeededForSubpath(subpath);
-            let index = insertionIndexForObjectInListSortedByFunction(resourceTreeElement, parent.children, this._boundCompareTreeElements);
-            parent.insertChild(resourceTreeElement, index);
+            let index = insertionIndexForObjectInListSortedByFunction(resourceTreeElement, parentTreeElement.children, this._boundCompareTreeElements);
+            parentTreeElement.insertChild(resourceTreeElement, index);
         }