Changeset 245206 in webkit


Ignore:
Timestamp:
May 11, 2019 1:58:52 PM (5 years ago)
Author:
Simon Fraser
Message:

When the scroller hosting a shared layer becomes non-scrollable, content disappears
https://bugs.webkit.org/show_bug.cgi?id=197766
<rdar://problem/50695808>

Reviewed by Zalan Bujtas.

Source/WebCore:

RenderLayerCompositor::requiresOwnBackingStore() should return true for a layer that shares
its backing store. We always made backing for overlap layers, so even if the sharing layers
have no painted content, this should rarely be a backing store memory regression.

Test: compositing/shared-backing/overflow-scroll/sharing-layer-becomes-non-scrollable.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):

LayoutTests:

  • compositing/shared-backing/overflow-scroll/sharing-layer-becomes-non-scrollable-expected.html: Added.
  • compositing/shared-backing/overflow-scroll/sharing-layer-becomes-non-scrollable.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r245205 r245206  
     12019-05-11  Simon Fraser  <simon.fraser@apple.com>
     2
     3        When the scroller hosting a shared layer becomes non-scrollable, content disappears
     4        https://bugs.webkit.org/show_bug.cgi?id=197766
     5        <rdar://problem/50695808>
     6
     7        Reviewed by Zalan Bujtas.
     8
     9        * compositing/shared-backing/overflow-scroll/sharing-layer-becomes-non-scrollable-expected.html: Added.
     10        * compositing/shared-backing/overflow-scroll/sharing-layer-becomes-non-scrollable.html: Added.
     11
    1122019-05-11  Simon Fraser  <simon.fraser@apple.com>
    213
  • trunk/Source/WebCore/ChangeLog

    r245205 r245206  
     12019-05-11  Simon Fraser  <simon.fraser@apple.com>
     2
     3        When the scroller hosting a shared layer becomes non-scrollable, content disappears
     4        https://bugs.webkit.org/show_bug.cgi?id=197766
     5        <rdar://problem/50695808>
     6
     7        Reviewed by Zalan Bujtas.
     8
     9        RenderLayerCompositor::requiresOwnBackingStore() should return true for a layer that shares
     10        its backing store. We always made backing for overlap layers, so even  if the sharing layers
     11        have no painted content, this should rarely be a backing store memory regression.
     12
     13        Test: compositing/shared-backing/overflow-scroll/sharing-layer-becomes-non-scrollable.html
     14
     15        * rendering/RenderLayerCompositor.cpp:
     16        (WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
     17
    1182019-05-11  Simon Fraser  <simon.fraser@apple.com>
    219
  • trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

    r245205 r245206  
    23672367        return true;
    23682368
     2369    if (layer.isComposited() && layer.backing()->hasBackingSharingLayers())
     2370        return true;
     2371
    23692372    return false;
    23702373}
Note: See TracChangeset for help on using the changeset viewer.