Changeset 245212 in webkit


Ignore:
Timestamp:
May 11, 2019 4:17:17 PM (5 years ago)
Author:
Simon Fraser
Message:

Overflow scroll that becomes non-scrollable should stop being composited
https://bugs.webkit.org/show_bug.cgi?id=197817
<rdar://problem/50697290>

Reviewed by Antti Koivisto.

Source/WebCore:

Remove the iOS-specific #ifdef around code that triggers a compositing re-evaluation
when scrolling state changes.

Test: compositing/scrolling/async-overflow-scrolling/become-non-scrollable.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout):

LayoutTests:

Put in a compositing/scrolling/async-overflow-scrolling dir so we can enable it only
for platforms that have async overflow scrolling.

  • TestExpectations:
  • compositing/scrolling/async-overflow-scrolling/become-non-scrollable-expected.txt: Added.
  • compositing/scrolling/async-overflow-scrolling/become-non-scrollable.html: Added.
  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
Location:
trunk
Files:
3 added
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r245211 r245212  
     12019-05-11  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Overflow scroll that becomes non-scrollable should stop being composited
     4        https://bugs.webkit.org/show_bug.cgi?id=197817
     5        <rdar://problem/50697290>
     6
     7        Reviewed by Antti Koivisto.
     8
     9        Put in a compositing/scrolling/async-overflow-scrolling dir so we can enable it only
     10        for platforms that have async overflow scrolling.
     11
     12        * TestExpectations:
     13        * compositing/scrolling/async-overflow-scrolling/become-non-scrollable-expected.txt: Added.
     14        * compositing/scrolling/async-overflow-scrolling/become-non-scrollable.html: Added.
     15        * platform/ios-wk2/TestExpectations:
     16        * platform/mac-wk2/TestExpectations:
     17
    1182019-05-11  Alexey Proskuryakov  <ap@apple.com>
    219
  • trunk/LayoutTests/TestExpectations

    r245170 r245212  
    6262# Requires async overflow scrolling
    6363compositing/shared-backing/overflow-scroll [ Skip ]
     64compositing/scrolling/async-overflow-scrolling [ Skip ]
    6465
    6566# WebKit2 only.
  • trunk/LayoutTests/platform/ios-wk2/TestExpectations

    r245209 r245212  
    99compositing/ios [ Pass ]
    1010compositing/shared-backing/overflow-scroll [ Pass ]
     11compositing/scrolling/async-overflow-scrolling [ Pass ]
    1112fast/device-orientation [ Pass ]
    1213fast/history/ios [ Pass ]
  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r245170 r245212  
    77
    88compositing/shared-backing/overflow-scroll [ Pass ]
     9compositing/scrolling/async-overflow-scrolling [ Pass ]
    910editing/find [ Pass ]
    1011editing/undo-manager [ Pass ]
  • trunk/Source/WebCore/ChangeLog

    r245208 r245212  
     12019-05-11  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Overflow scroll that becomes non-scrollable should stop being composited
     4        https://bugs.webkit.org/show_bug.cgi?id=197817
     5        <rdar://problem/50697290>
     6
     7        Reviewed by Antti Koivisto.
     8
     9        Remove the iOS-specific #ifdef around code that triggers a compositing re-evaluation
     10        when scrolling state changes.
     11
     12        Test: compositing/scrolling/async-overflow-scrolling/become-non-scrollable.html
     13
     14        * rendering/RenderLayer.cpp:
     15        (WebCore::RenderLayer::updateScrollInfoAfterLayout):
     16
    1172019-05-11  Simon Fraser  <simon.fraser@apple.com>
    218
  • trunk/Source/WebCore/rendering/RenderLayer.cpp

    r245205 r245212  
    37103710    }
    37113711
    3712 #if PLATFORM(IOS_FAMILY)
    37133712    if (canUseCompositedScrolling())
    37143713        setNeedsPostLayoutCompositingUpdate();
    3715 #endif
    37163714
    37173715    updateScrollSnapState();
Note: See TracChangeset for help on using the changeset viewer.