Changeset 245250 in webkit


Ignore:
Timestamp:
May 13, 2019 2:06:56 PM (5 years ago)
Author:
Megan Gardner
Message:

Alter Conic Gradient tests to be less subject to noise
​https://bugs.webkit.org/show_bug.cgi?id=197806
<rdar://problem/47272067>

Reviewed by Wenson Hsieh.

There is a currently a bug where there's a lot of detectable noise in
the green gradients. Replace them with the less noisy magenta or blue.
<rdar://problem/50682535>

  • fast/gradients/conic-extended-stops-expected.html:
  • fast/gradients/conic-extended-stops.html:
  • fast/gradients/conic-from-angle-expected.html:
  • fast/gradients/conic-from-angle.html:
  • fast/gradients/conic-gradient-expected.html:
  • fast/gradients/conic-gradient-extended-stops-expected.html:
  • fast/gradients/conic-gradient-extended-stops.html:
  • fast/gradients/conic-gradient.html:
  • fast/gradients/conic-off-center-expected.html:
  • fast/gradients/conic-off-center.html:
  • fast/gradients/conic-two-hints-expected.html:
  • fast/gradients/conic-two-hints.html:
Location:
trunk/LayoutTests
Files:
13 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r245242 r245250  
     12019-05-13  Megan Gardner  <megan_gardner@apple.com>
     2
     3        Alter Conic Gradient tests to be less subject to noise
     4        https://bugs.webkit.org/show_bug.cgi?id=197806
     5        <rdar://problem/47272067>
     6
     7        Reviewed by Wenson Hsieh.
     8
     9        There is a currently a bug where there's a lot of detectable noise in
     10        the green gradients. Replace them with the less noisy magenta or blue.
     11        <rdar://problem/50682535>
     12
     13        * fast/gradients/conic-extended-stops-expected.html:
     14        * fast/gradients/conic-extended-stops.html:
     15        * fast/gradients/conic-from-angle-expected.html:
     16        * fast/gradients/conic-from-angle.html:
     17        * fast/gradients/conic-gradient-expected.html:
     18        * fast/gradients/conic-gradient-extended-stops-expected.html:
     19        * fast/gradients/conic-gradient-extended-stops.html:
     20        * fast/gradients/conic-gradient.html:
     21        * fast/gradients/conic-off-center-expected.html:
     22        * fast/gradients/conic-off-center.html:
     23        * fast/gradients/conic-two-hints-expected.html:
     24        * fast/gradients/conic-two-hints.html:
     25
    1262019-05-13  Antti Koivisto  <antti@apple.com>
    227

  • trunk/LayoutTests/fast/gradients/conic-extended-stops-expected.html

    r235772 r245250  
    1515            width: 25px;
    1616            clear: left;
    17             background-color: green;
     17            background-color: magenta;
    1818        }
    1919        #box3 {

  • trunk/LayoutTests/fast/gradients/conic-extended-stops.html

    r235772 r245250  
    55            height: 50px;
    66            width: 50px;
    7             background: conic-gradient(blue -50deg, blue 90deg, orange 90deg, orange 180deg, green 180deg, green 270deg, blue 270deg, blue 540deg);
     7            background: conic-gradient(blue -50deg, blue 90deg, orange 90deg, orange 180deg, magenta 180deg, magenta 270deg, blue 270deg, blue 540deg);
    88        }
    99    </style>

  • trunk/LayoutTests/fast/gradients/conic-from-angle-expected.html

    r235868 r245250  
    99            width: 0;
    1010            height: 0;
    11             border-left: 100px solid green;
     11            border-left: 100px solid magenta;
    1212            border-right: 100px solid blue;
    1313            border-top: 100px solid yellow;
    … …  
    1616            width: 0;
    1717            height: 0;
    18             border-left: 100px solid green;
     18            border-left: 100px solid magenta;
    1919            border-right: 100px solid blue;
    2020            border-bottom: 100px solid orange;

  • trunk/LayoutTests/fast/gradients/conic-from-angle.html

    r235868 r245250  
    1111                blue 0deg, blue 90deg,
    1212                orange 0deg, orange 180deg,
    13                 green 0deg, green 270deg,
     13                magenta 0deg, magenta 270deg,
    1414                yellow 0deg, yellow 360deg);
    1515        }

  • trunk/LayoutTests/fast/gradients/conic-gradient-expected.html

    r236027 r245250  
    1010            width: 0;
    1111            height: 0;
    12             border-left: 100px solid rgb(0,32,0);
     12            border-left: 100px solid rgb(0,0,32);
    1313            border-top: 100px solid rgb(0,0,0);
    1414        }
    … …  
    1616            width: 0;
    1717            height: 0;
    18             border-right: 100px solid rgb(0,192,0);
    19             border-top: 100px solid rgb(0,224,0);
     18            border-right: 100px solid rgb(0,0,192);
     19            border-top: 100px solid rgb(0,0,224);
    2020        }
    2121        #bottomleft {
    … …  
    2323            width: 0;
    2424            height: 0;
    25             border-left: 100px solid rgb(0,64,0);
    26             border-bottom: 100px solid rgb(0,96,0);
     25            border-left: 100px solid rgb(0,0,64);
     26            border-bottom: 100px solid rgb(0,0,96);
    2727        }
    2828        #bottomright {
    2929            width: 0;
    3030            height: 0;
    31             border-right: 100px solid rgb(0,160,0);
    32             border-bottom: 100px solid rgb(0,128,0);
     31            border-right: 100px solid rgb(0,0,159);
     32            border-bottom: 100px solid rgb(0,0,128);
    3333        }
    3434        .box {

  • trunk/LayoutTests/fast/gradients/conic-gradient-extended-stops-expected.html

    r236027 r245250  
    1010            width: 0;
    1111            height: 0;
    12             border-left: 100px solid rgb(0,80,0);
    13             border-top: 100px solid rgb(0,64,0);
     12            border-left: 100px solid rgb(0,0,80);
     13            border-top: 100px solid rgb(0,0,64);
    1414        }
    1515        #topright {
    1616            width: 0;
    1717            height: 0;
    18             border-right: 100px solid rgb(0,160,0);
    19             border-top: 100px solid rgb(0,176,0);
     18            border-right: 100px solid rgb(0,0,159);
     19            border-top: 100px solid rgb(0,0,175);
    2020        }
    2121        #bottomleft {
    … …  
    2323            width: 0;
    2424            height: 0;
    25             border-left: 100px solid rgb(0,96,0);
    26             border-bottom: 100px solid rgb(0,112,0);
     25            border-left: 100px solid rgb(0,0,96);
     26            border-bottom: 100px solid rgb(0,0,112);
    2727        }
    2828        #bottomright {
    2929            width: 0;
    3030            height: 0;
    31             border-right: 100px solid rgb(0,144,0);
    32             border-bottom: 100px solid rgb(0,128,0);
     31            border-right: 100px solid rgb(0,0,143);
     32            border-bottom: 100px solid rgb(0,0,128);
    3333        }
    3434        .box {

  • trunk/LayoutTests/fast/gradients/conic-gradient-extended-stops.html

    r236027 r245250  
    1414        width: 200px;
    1515        height: 200px;
    16         background-image: conic-gradient(lime -180deg, black 540deg);
     16        background-image: conic-gradient(blue -180deg, black 540deg);
    1717        filter: url(#posterize);
    1818    }

  • trunk/LayoutTests/fast/gradients/conic-gradient.html

    r236027 r245250  
    1414        width: 200px;
    1515        height: 200px;
    16         background-image: conic-gradient(lime, black);
     16        background-image: conic-gradient(blue, black);
    1717        filter: url(#posterize);
    1818    }

  • trunk/LayoutTests/fast/gradients/conic-off-center-expected.html

    r235772 r245250  
    1515            width: 10px;
    1616            clear: left;
    17             background-color: green;
     17            background-color: magenta;
    1818        }
    1919        #box3 {

  • trunk/LayoutTests/fast/gradients/conic-off-center.html

    r235772 r245250  
    55            height: 50px;
    66            width: 50px;
    7             background: conic-gradient(at 10px 10px, blue 0deg, blue 90deg, orange 90deg, orange 180deg, green 180deg, green 270deg, blue 270deg, blue 360deg);
     7            background: conic-gradient(at 10px 10px, blue 0deg, blue 90deg, orange 90deg, orange 180deg, magenta 180deg, magenta 270deg, blue 270deg, blue 360deg);
    88        }
    99    </style>

  • trunk/LayoutTests/fast/gradients/conic-two-hints-expected.html

    r236155 r245250  
    2020            width: 25px;
    2121            clear: left;
    22             background-color: green;
     22            background-color: magenta;
    2323        }
    2424    </style>

  • trunk/LayoutTests/fast/gradients/conic-two-hints.html

    r236155 r245250  
    55            height: 50px;
    66            width: 50px;
    7             background: conic-gradient(blue 0deg 90deg, green 90deg 180deg, orange 180deg 360deg);
     7            background: conic-gradient(blue 0deg 90deg, magenta 90deg 180deg, orange 180deg 360deg);
    88        }
    99    </style>
Note: See TracChangeset for help on using the changeset viewer.