Changeset 245253 in webkit


Ignore:
Timestamp:
May 13, 2019 2:52:35 PM (5 years ago)
Author:
ggaren@apple.com
Message:

Downgrade RELEASE_ASSERT TO RELEASE_LOG_FAULT for SQLite Class A files
https://bugs.webkit.org/show_bug.cgi?id=197760

Reviewed by Jer Noble.

Only makeSafeToUseMemoryMapForPath() if needed. (Fixed missing brace.)

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::open):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r245249 r245253  
     12019-05-13  Geoffrey Garen  <ggaren@apple.com>
     2
     3        Downgrade RELEASE_ASSERT TO RELEASE_LOG_FAULT for SQLite Class A files
     4        https://bugs.webkit.org/show_bug.cgi?id=197760
     5
     6        Reviewed by Jer Noble.
     7
     8        Only makeSafeToUseMemoryMapForPath() if needed. (Fixed missing brace.)
     9
     10        * platform/sql/SQLiteDatabase.cpp:
     11        (WebCore::SQLiteDatabase::open):
     12
    1132019-05-13  Tadeu Zagallo  <tzagallo@apple.com>
    214
  • trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp

    r245197 r245253  
    152152    String shmFileName = makeString(filename, "-shm"_s);
    153153    if (FileSystem::fileExists(shmFileName)) {
    154         if (!FileSystem::isSafeToUseMemoryMapForPath(shmFileName))
     154        if (!FileSystem::isSafeToUseMemoryMapForPath(shmFileName)) {
    155155            RELEASE_LOG_FAULT(SQLDatabase, "Opened an SQLite database with a Class A -shm file. This may trigger a crash when the user locks the device. (%s)", shmFileName.latin1().data());
    156156            FileSystem::makeSafeToUseMemoryMapForPath(shmFileName);
     157        }
    157158    }
    158159
Note: See TracChangeset for help on using the changeset viewer.