Changeset 245295 in webkit


Ignore:
Timestamp:
May 14, 2019 12:06:23 PM (5 years ago)
Author:
Oriol Brufau
Message:

[css-grid] Update grid when changing auto repeat type
​https://bugs.webkit.org/show_bug.cgi?id=197849

Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

Import WPT test.

  • web-platform-tests/css/css-grid/grid-definition/grid-change-auto-repeat-tracks-expected.txt: Added.
  • web-platform-tests/css/css-grid/grid-definition/grid-change-auto-repeat-tracks.html: Added.
  • web-platform-tests/css/css-grid/grid-definition/w3c-import.log:

Source/WebCore:

Test: imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-change-auto-repeat-tracks.html

This patch makes two 'repeat()' values for 'grid-template' be considered
to be different if one uses 'auto-fill' and the other 'auto-fit'.

Previously, they were considered to be equal if the repeated values
were the same, without comparing the repeat type. Therefore, the grid
was not updated when setting both values one after the other.

  • css/CSSGridAutoRepeatValue.cpp:

(WebCore::CSSGridAutoRepeatValue::equals const):

  • css/CSSGridAutoRepeatValue.h:

LayoutTests:

Remove the test which has been upstreamed to WPT.

  • fast/css-grid-layout/grid-change-auto-repeat-tracks-expected.txt: Removed.
  • fast/css-grid-layout/grid-change-auto-repeat-tracks.html: Removed.
Location:
trunk
Files:
2 added
2 deleted
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r245293 r245295  
     12019-05-14  Oriol Brufau  <obrufau@igalia.com>
     2
     3        [css-grid] Update grid when changing auto repeat type
     4        https://bugs.webkit.org/show_bug.cgi?id=197849
     5
     6        Reviewed by Javier Fernandez.
     7
     8        Remove the test which has been upstreamed to WPT.
     9
     10        * fast/css-grid-layout/grid-change-auto-repeat-tracks-expected.txt: Removed.
     11        * fast/css-grid-layout/grid-change-auto-repeat-tracks.html: Removed.
     12
    1132019-05-14  Antti Koivisto  <antti@apple.com>
    214

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r245279 r245295  
     12019-05-14  Oriol Brufau  <obrufau@igalia.com>
     2
     3        [css-grid] Update grid when changing auto repeat type
     4        https://bugs.webkit.org/show_bug.cgi?id=197849
     5
     6        Reviewed by Javier Fernandez.
     7
     8        Import WPT test.
     9
     10        * web-platform-tests/css/css-grid/grid-definition/grid-change-auto-repeat-tracks-expected.txt: Added.
     11        * web-platform-tests/css/css-grid/grid-definition/grid-change-auto-repeat-tracks.html: Added.
     12        * web-platform-tests/css/css-grid/grid-definition/w3c-import.log:
     13
    1142019-05-14  Manuel Rego Casasnovas  <rego@igalia.com>
    215

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/w3c-import.log

    r245279 r245295  
    2424/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-001.html
    2525/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-min-size-002.html
     26/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-change-auto-repeat-tracks.html
    2627/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-change-fit-content-argument-001.html
    2728/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-inline-auto-repeat-001.html

  • trunk/Source/WebCore/ChangeLog

    r245293 r245295  
     12019-05-14  Oriol Brufau  <obrufau@igalia.com>
     2
     3        [css-grid] Update grid when changing auto repeat type
     4        https://bugs.webkit.org/show_bug.cgi?id=197849
     5
     6        Reviewed by Javier Fernandez.
     7
     8        Test: imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-change-auto-repeat-tracks.html
     9
     10        This patch makes two 'repeat()' values for 'grid-template' be considered
     11        to be different if one uses 'auto-fill' and the other 'auto-fit'.
     12
     13        Previously, they were considered to be equal if the repeated values
     14        were the same, without comparing the repeat type. Therefore, the grid
     15        was not updated when setting both values one after the other.
     16
     17        * css/CSSGridAutoRepeatValue.cpp:
     18        (WebCore::CSSGridAutoRepeatValue::equals const):
     19        * css/CSSGridAutoRepeatValue.h:
     20
    1212019-05-14  Antti Koivisto  <antti@apple.com>
    222

  • trunk/Source/WebCore/css/CSSGridAutoRepeatValue.cpp

    r219115 r245295  
    4747}
    4848
     49bool CSSGridAutoRepeatValue::equals(const CSSGridAutoRepeatValue& other) const
     50{
     51    return m_autoRepeatID == other.m_autoRepeatID && CSSValueList::equals(other);
     52}
     53
    4954} // namespace WebCore

  • trunk/Source/WebCore/css/CSSGridAutoRepeatValue.h

    r212629 r245295  
    5555
    5656    String customCSSText() const;
     57    bool equals(const CSSGridAutoRepeatValue&) const;
     58
    5759    CSSValueID autoRepeatID() const { return m_autoRepeatID; }
    5860
Note: See TracChangeset for help on using the changeset viewer.