Changeset 245302 in webkit


Ignore:
Timestamp:
May 14, 2019 1:35:32 PM (5 years ago)
Author:
rmorisset@apple.com
Message:

[WHLSL] parseEffectfulAssignment should not call parseCallExpression directly
https://bugs.webkit.org/show_bug.cgi?id=197890

Reviewed by Myles Maxfield.

callExpression already appears in effSuffix which is in effPrefix which is in effAssignment, so having it directly in effAssignment as well is useless (and ambiguous).
I've already fixed the grammar (https://github.com/gpuweb/WHLSL/commit/a07005f4d692fe3370618dca5db218992b362049), the grammar was always good, this patch is fixing the parser.

  • Modules/webgpu/WHLSL/WHLSLParser.cpp:

(WebCore::WHLSL::Parser::parseEffectfulAssignment):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r245301 r245302  
     12019-05-14  Robin Morisset  <rmorisset@apple.com>
     2
     3        [WHLSL] parseEffectfulAssignment should not call parseCallExpression directly
     4        https://bugs.webkit.org/show_bug.cgi?id=197890
     5
     6        Reviewed by Myles Maxfield.
     7
     8        callExpression already appears in effSuffix which is in effPrefix which is in effAssignment, so having it directly in effAssignment as well is useless (and ambiguous).
     9        I've already fixed the grammar (https://github.com/gpuweb/WHLSL/commit/a07005f4d692fe3370618dca5db218992b362049), the grammar was always good, this patch is fixing the parser.
     10
     11        * Modules/webgpu/WHLSL/WHLSLParser.cpp:
     12        (WebCore::WHLSL::Parser::parseEffectfulAssignment):
     13
    1142019-05-14  Ross Kirsling  <ross.kirsling@sony.com>
    215
  • trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp

    r243091 r245302  
    18001800    assignment = backtrackingScope<Expected<UniqueRef<AST::Expression>, Error>>([&]() {
    18011801        return parseEffectfulPrefix();
    1802     });
    1803     if (assignment)
    1804         return assignment;
    1805 
    1806     assignment = backtrackingScope<Expected<UniqueRef<AST::Expression>, Error>>([&]() {
    1807         return parseCallExpression();
    18081802    });
    18091803    if (assignment)
Note: See TracChangeset for help on using the changeset viewer.