Changeset 245316 in webkit

Timestamp:

May 14, 2019 9:00:05 PM (5 years ago)

Author:

Megan Gardner

Message:

Fix flakey test fast/events/autoscroll-when-input-is-offscreen.html
​https://bugs.webkit.org/show_bug.cgi?id=197897
<rdar://problem/50306931>

Reviewed by Wenson Hsieh.

Programmatic scrolls are included in the transaction and we want to
ensure that they've been applied. Then we can be sure that the page
has finished scrolling and it's appropriate to test the page offset.

• fast/events/autoscroll-when-input-is-offscreen.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/events/autoscroll-when-input-is-offscreen.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-05-14  Megan Gardner  <megan_gardner@apple.com>
+
+        Fix flakey test fast/events/autoscroll-when-input-is-offscreen.html
+        https://bugs.webkit.org/show_bug.cgi?id=197897
+        <rdar://problem/50306931>
+
+        Reviewed by Wenson Hsieh.
+
+        Programmatic scrolls are included in the transaction and we want to 
+        ensure that they've been applied. Then we can be sure that the page 
+        has finished scrolling and it's appropriate to test the page offset. 
+
+        * fast/events/autoscroll-when-input-is-offscreen.html:
+
 2019-05-14  Shawn Roberts  <sroberts@apple.com>
 

trunk/LayoutTests/fast/events/autoscroll-when-input-is-offscreen.html

@@ -20 +20 @@
         await UIHelper.activateElementAndWaitForInputSession(document.getElementById('editable'));
         
-        var programaticScroll = 500;
-        document.scrollingElement.scrollTop = programaticScroll;
+        var programmaticScroll = 500;
+        document.scrollingElement.scrollTop = programmaticScroll;
         await UIHelper.enterText("Test");
-
-        if (window.pageYOffset < programaticScroll)
+        await UIHelper.ensurePresentationUpdate();
+        if (window.pageYOffset < programmaticScroll)
             output += 'PASS: page has scrolled back to the top to show the element that has text being entered into it.';
         else