Changeset 245365 in webkit


Ignore:
Timestamp:
May 15, 2019 3:41:59 PM (5 years ago)
Author:
aakash_jain@apple.com
Message:

Replace double-quotes with single quotes in steps.py
​https://bugs.webkit.org/show_bug.cgi?id=197921

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-build/steps.py:
Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/ews-build/steps.py

    r245141 r245365  
    4040
    4141class ConfigureBuild(buildstep.BuildStep):
    42     name = "configure-build"
    43     description = ["configuring build"]
    44     descriptionDone = ["Configured build"]
     42    name = 'configure-build'
     43    description = ['configuring build']
     44    descriptionDone = ['Configured build']
    4545
    4646    def __init__(self, platform, configuration, architectures, buildOnly, triggers, additionalArguments):
    … …  
    5151        self.fullPlatform = platform
    5252        self.configuration = configuration
    53         self.architecture = " ".join(architectures) if architectures else None
     53        self.architecture = ' '.join(architectures) if architectures else None
    5454        self.buildOnly = buildOnly
    5555        self.triggers = triggers
    … …  
    6666            self.setProperty('architecture', self.architecture, 'config.json')
    6767        if self.buildOnly:
    68             self.setProperty("buildOnly", self.buildOnly, 'config.json')
     68            self.setProperty('buildOnly', self.buildOnly, 'config.json')
    6969        if self.triggers:
    7070            self.setProperty('triggers', self.triggers, 'config.json')
    7171        if self.additionalArguments:
    72             self.setProperty("additionalArguments", self.additionalArguments, 'config.json')
     72            self.setProperty('additionalArguments', self.additionalArguments, 'config.json')
    7373
    7474        self.add_patch_id_url()
    … …  
    154154
    155155    bindings_paths = [
    156         "Source/WebCore",
    157         "Tools",
     156        'Source/WebCore',
     157        'Tools',
    158158    ]
    159159
    160160    jsc_paths = [
    161         "JSTests/",
    162         "Source/JavaScriptCore/",
    163         "Source/WTF/",
    164         "Source/bmalloc/",
    165         "Makefile",
    166         "Makefile.shared",
    167         "Source/Makefile",
    168         "Source/Makefile.shared",
    169         "Tools/Scripts/build-webkit",
    170         "Tools/Scripts/build-jsc",
    171         "Tools/Scripts/jsc-stress-test-helpers/",
    172         "Tools/Scripts/run-jsc",
    173         "Tools/Scripts/run-jsc-benchmarks",
    174         "Tools/Scripts/run-jsc-stress-tests",
    175         "Tools/Scripts/run-javascriptcore-tests",
    176         "Tools/Scripts/run-layout-jsc",
    177         "Tools/Scripts/update-javascriptcore-test-results",
    178         "Tools/Scripts/webkitdirs.pm",
     161        'JSTests/',
     162        'Source/JavaScriptCore/',
     163        'Source/WTF/',
     164        'Source/bmalloc/',
     165        'Makefile',
     166        'Makefile.shared',
     167        'Source/Makefile',
     168        'Source/Makefile.shared',
     169        'Tools/Scripts/build-webkit',
     170        'Tools/Scripts/build-jsc',
     171        'Tools/Scripts/jsc-stress-test-helpers/',
     172        'Tools/Scripts/run-jsc',
     173        'Tools/Scripts/run-jsc-benchmarks',
     174        'Tools/Scripts/run-jsc-stress-tests',
     175        'Tools/Scripts/run-javascriptcore-tests',
     176        'Tools/Scripts/run-layout-jsc',
     177        'Tools/Scripts/update-javascriptcore-test-results',
     178        'Tools/Scripts/webkitdirs.pm',
    179179    ]
    180180
    181181    webkitpy_paths = [
    182         "Tools/Scripts/webkitpy/",
    183         "Tools/QueueStatusServer/",
     182        'Tools/Scripts/webkitpy/',
     183        'Tools/QueueStatusServer/',
    184184    ]
    185185
    … …  
    243243    flunkOnFailure = True
    244244    haltOnFailure = True
    245     bug_open_statuses = ["UNCONFIRMED", "NEW", "ASSIGNED", "REOPENED"]
    246     bug_closed_statuses = ["RESOLVED", "VERIFIED", "CLOSED"]
     245    bug_open_statuses = ['UNCONFIRMED', 'NEW', 'ASSIGNED', 'REOPENED']
     246    bug_closed_statuses = ['RESOLVED', 'VERIFIED', 'CLOSED']
    247247
    248248    @defer.inlineCallbacks
    … …  
    405405
    406406class TestWithFailureCount(shell.Test):
    407     failedTestsFormatString = "%d test%s failed"
     407    failedTestsFormatString = '%d test%s failed'
    408408    failedTestCount = 0
    409409
    … …  
    419419        shell.Test.commandComplete(self, cmd)
    420420        self.failedTestCount = self.countFailures(cmd)
    421         self.failedTestPluralSuffix = "" if self.failedTestCount == 1 else "s"
     421        self.failedTestPluralSuffix = '' if self.failedTestCount == 1 else 's'
    422422
    423423    def evaluateCommand(self, cmd):
    … …  
    580580
    581581class CompileWebKit(shell.Compile):
    582     name = "compile-webkit"
    583     description = ["compiling"]
    584     descriptionDone = ["Compiled WebKit"]
     582    name = 'compile-webkit'
     583    description = ['compiling']
     584    descriptionDone = ['Compiled WebKit']
    585585    env = {'MFLAGS': ''}
    586     warningPattern = ".*arning: .*"
     586    warningPattern = '.*arning: .*'
    587587    haltOnFailure = False
    588     command = ["perl", "Tools/Scripts/build-webkit", WithProperties("--%(configuration)s")]
     588    command = ['perl', 'Tools/Scripts/build-webkit', WithProperties('--%(configuration)s')]
    589589
    590590    def start(self):
    … …  
    636636
    637637class CompileJSCOnly(CompileWebKit):
    638     name = "build-jsc"
    639     descriptionDone = ["Compiled JSC"]
    640     command = ["perl", "Tools/Scripts/build-jsc", WithProperties("--%(configuration)s")]
     638    name = 'build-jsc'
     639    descriptionDone = ['Compiled JSC']
     640    command = ['perl', 'Tools/Scripts/build-jsc', WithProperties('--%(configuration)s')]
    641641
    642642
    … …  
    657657    flunkOnFailure = True
    658658    jsonFileName = 'jsc_results.json'
    659     logfiles = {"json": jsonFileName}
     659    logfiles = {'json': jsonFileName}
    660660    command = ['perl', 'Tools/Scripts/run-javascriptcore-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(jsonFileName), WithProperties('--%(configuration)s')]
    661661
    … …  
    698698
    699699class CleanBuild(shell.Compile):
    700     name = "delete-WebKitBuild-directory"
    701     description = ["deleting WebKitBuild directory"]
    702     descriptionDone = ["Deleted WebKitBuild directory"]
    703     command = ["python", "Tools/BuildSlaveSupport/clean-build", WithProperties("--platform=%(fullPlatform)s"), WithProperties("--%(configuration)s")]
     700    name = 'delete-WebKitBuild-directory'
     701    description = ['deleting WebKitBuild directory']
     702    descriptionDone = ['Deleted WebKitBuild directory']
     703    command = ['python', 'Tools/BuildSlaveSupport/clean-build', WithProperties('--platform=%(fullPlatform)s'), WithProperties('--%(configuration)s')]
    704704
    705705
    706706class KillOldProcesses(shell.Compile):
    707     name = "kill-old-processes"
    708     description = ["killing old processes"]
    709     descriptionDone = ["Killed old processes"]
    710     command = ["python", "Tools/BuildSlaveSupport/kill-old-processes", "buildbot"]
     707    name = 'kill-old-processes'
     708    description = ['killing old processes']
     709    descriptionDone = ['Killed old processes']
     710    command = ['python', 'Tools/BuildSlaveSupport/kill-old-processes', 'buildbot']
    711711
    712712    def __init__(self, **kwargs):

  • trunk/Tools/ChangeLog

    r245364 r245365  
     12019-05-15  Aakash Jain  <aakash_jain@apple.com>
     2
     3        Replace double-quotes with single quotes in steps.py
     4        https://bugs.webkit.org/show_bug.cgi?id=197921
     5
     6        Reviewed by Jonathan Bedard.
     7
     8        * BuildSlaveSupport/ews-build/steps.py:
     9
    1102019-05-15  Keith Rollin  <krollin@apple.com>
    211
Note: See TracChangeset for help on using the changeset viewer.