Changeset 245394 in webkit

Timestamp:

May 16, 2019 4:48:52 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

[WPE] Rendering on a HiDPI display looks scaled up instead of rendered at 2x
​https://bugs.webkit.org/show_bug.cgi?id=185764

Patch by Ryan Walklin <​ryan@testtoast.com> on 2019-05-16
Reviewed by Carlos Garcia Campos.

Add a function to the wpe_view_backend_client struct which accepts a device scale factor
configured through wpe_view_backend_dispatch_set_device_scale_factor() and calls
setIntrinsicDeviceScaleFactor for the the current View.Page object. The
function definition has been added in libwpe 1.3.

• UIProcess/API/wpe/WPEView.cpp:

(WKWPE::m_backend): Add set_device_scale_factor implementation declared by libwpe.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/wpe/WPEView.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-05-16  Ryan Walklin  <ryan@testtoast.com>
+
+        [WPE] Rendering on a HiDPI display looks scaled up instead of rendered at 2x
+        https://bugs.webkit.org/show_bug.cgi?id=185764
+
+        Reviewed by Carlos Garcia Campos.
+
+        Add a function to the wpe_view_backend_client struct which accepts a device scale factor
+        configured through wpe_view_backend_dispatch_set_device_scale_factor() and calls
+        setIntrinsicDeviceScaleFactor for the the current View.Page object. The
+        function definition has been added in libwpe 1.3.
+
+        * UIProcess/API/wpe/WPEView.cpp:
+        (WKWPE::m_backend): Add set_device_scale_factor implementation declared by libwpe.
+
 2019-05-15  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebKit/UIProcess/API/wpe/WPEView.cpp

@@ -101 +101 @@
             view.setViewState(flags);
         },
-        // padding
-        nullptr,
-        nullptr,
+        // get_accessible
+        nullptr,
+#if WPE_CHECK_VERSION(1, 3, 0)
+        // set_device_scale_factor
+        [](void* data, float scale)
+        {
+            auto& view = *reinterpret_cast<View*>(data);
+            view.page().setIntrinsicDeviceScaleFactor(scale);
+        },
+#else
+        nullptr,
+#endif // WPE_CHECK_VERSION(1, 3, 0)
+        // padding,
         nullptr
     };