Changeset 245487 in webkit


Ignore:
Timestamp:
May 17, 2019 4:41:47 PM (5 years ago)
Author:
aakash_jain@apple.com
Message:

[ews-app] Status bubble should not turn orange when any build step has warnings
https://bugs.webkit.org/show_bug.cgi?id=198000

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble._does_build_contains_any_failed_step):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py

    r245282 r245487  
    156156    def _does_build_contains_any_failed_step(self, build):
    157157        for step in build.step_set.all():
    158             if step.result and step.result != Buildbot.SUCCESS:
     158            if step.result and step.result != Buildbot.SUCCESS and step.result != Buildbot.WARNINGS:
    159159                return True
    160160        return False
  • trunk/Tools/ChangeLog

    r245481 r245487  
     12019-05-17  Aakash Jain  <aakash_jain@apple.com>
     2
     3        [ews-app] Status bubble should not turn orange when any build step has warnings
     4        https://bugs.webkit.org/show_bug.cgi?id=198000
     5
     6        Reviewed by Jonathan Bedard.
     7
     8        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
     9        (StatusBubble._does_build_contains_any_failed_step):
     10
    1112019-05-17  Alex Christensen  <achristensen@webkit.org>
    212
Note: See TracChangeset for help on using the changeset viewer.