Changeset 245695 in webkit

Timestamp:

May 23, 2019 11:02:13 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

[Pointer Events] The mouseover, mouseout, mouseenter, and mouseleave events should not be prevented while the pointer is down
​https://bugs.webkit.org/show_bug.cgi?id=198177

Patch by Antoine Quint <Antoine Quint> on 2019-05-23
Reviewed by Dean Jackson.

Source/WebCore:

Test: pointerevents/mouse/compatibility-mouse-events-prevention-mouse-pressed.html

The Pointer Event spec, in ​https://www.w3.org/TR/pointerevents/#compatibility-mapping-with-mouse-events, says that "the mouseover,
mouseout, mouseenter, and mouseleave events are never prevented (even if the pointer is down)." We add a new static function which
indicates what is "compatibility" mouse event since those should be excluded, along with "click", which we already excluded.

• dom/Element.cpp:

(WebCore::isCompatibilityMouseEvent):
(WebCore::Element::dispatchMouseEvent):

LayoutTests:

Add a test that listens to all mouse events and checks which are dispatched in the case preventDefault() is called when handling
"pointerdown" and when it isn't.

• platform/mac-wk1/TestExpectations: Skipping the test on WK1 where the sequence of dispatched mouse events does not match.
• pointerevents/mouse/compatibility-mouse-events-prevention-mouse-pressed-expected.txt: Added.
• pointerevents/mouse/compatibility-mouse-events-prevention-mouse-pressed.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac-wk1/TestExpectations (modified) (1 diff)
• LayoutTests/pointerevents/mouse/compatibility-mouse-events-prevention-mouse-pressed-expected.txt (added)
• LayoutTests/pointerevents/mouse/compatibility-mouse-events-prevention-mouse-pressed.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Element.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-05-23  Antoine Quint  <graouts@apple.com>
+
+        [Pointer Events] The mouseover, mouseout, mouseenter, and mouseleave events should not be prevented while the pointer is down
+        https://bugs.webkit.org/show_bug.cgi?id=198177
+
+        Reviewed by Dean Jackson.
+
+        Add a test that listens to all mouse events and checks which are dispatched in the case preventDefault() is called when handling
+        "pointerdown" and when it isn't.
+
+        * platform/mac-wk1/TestExpectations: Skipping the test on WK1 where the sequence of dispatched mouse events does not match.
+        * pointerevents/mouse/compatibility-mouse-events-prevention-mouse-pressed-expected.txt: Added.
+        * pointerevents/mouse/compatibility-mouse-events-prevention-mouse-pressed.html: Added.
+
 2019-05-23  Truitt Savell  <tsavell@apple.com>
 

trunk/LayoutTests/platform/mac-wk1/TestExpectations

@@ -700 +700 @@
 webkit.org/b/195623 http/tests/cache/link-prefetch-main-resource.html [ Skip ]
 webkit.org/b/195623 http/tests/cache/link-prefetch-main-resource-iframe.html [ Skip ]
+
+webkit.org/b/198177 pointerevents/mouse/compatibility-mouse-events-prevention-mouse-pressed.html [ Skip ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-23  Antoine Quint  <graouts@apple.com>
+
+        [Pointer Events] The mouseover, mouseout, mouseenter, and mouseleave events should not be prevented while the pointer is down
+        https://bugs.webkit.org/show_bug.cgi?id=198177
+
+        Reviewed by Dean Jackson.
+
+        Test: pointerevents/mouse/compatibility-mouse-events-prevention-mouse-pressed.html
+
+        The Pointer Event spec, in https://www.w3.org/TR/pointerevents/#compatibility-mapping-with-mouse-events, says that "the mouseover,
+        mouseout, mouseenter, and mouseleave events are never prevented (even if the pointer is down)." We add a new static function which
+        indicates what is "compatibility" mouse event since those should be excluded, along with "click", which we already excluded.
+
+        * dom/Element.cpp:
+        (WebCore::isCompatibilityMouseEvent):
+        (WebCore::Element::dispatchMouseEvent):
+
 2019-05-23  Jon Davis  <jond@apple.com>
 

trunk/Source/WebCore/dom/Element.cpp

@@ -289 +289 @@
 }
 
+static bool isCompatibilityMouseEvent(const MouseEvent& mouseEvent)
+{
+    // https://www.w3.org/TR/pointerevents/#compatibility-mapping-with-mouse-events
+    const auto& type = mouseEvent.type();
+    return type != eventNames().clickEvent && type != eventNames().mouseoverEvent && type != eventNames().mouseoutEvent && type != eventNames().mouseenterEvent && type != eventNames().mouseleaveEvent;
+}
+
 bool Element::dispatchMouseEvent(const PlatformMouseEvent& platformEvent, const AtomicString& eventType, int detail, Element* relatedTarget)
 {
@@ -315 +322 @@
             if (auto* page = document().page()) {
                 page->pointerCaptureController().dispatchEvent(*pointerEvent, this);
-                if (mouseEvent->type() != eventNames().clickEvent && page->pointerCaptureController().preventsCompatibilityMouseEventsForIdentifier(pointerEvent->pointerId()))
+                if (isCompatibilityMouseEvent(mouseEvent) && page->pointerCaptureController().preventsCompatibilityMouseEventsForIdentifier(pointerEvent->pointerId()))
                     return false;
             }