Changeset 245710 in webkit

Timestamp:

May 23, 2019 1:43:49 PM (5 years ago)

Author:

Tadeu Zagallo

Message:

DFG::OSREntry should not perform arity check
​https://bugs.webkit.org/show_bug.cgi?id=198189

Reviewed by Saam Barati.

JSTests:

• microbenchmarks/loop-osr-with-arity-mismatch.js: Added.

(foo):

Source/JavaScriptCore:

The check prevents OSR entering from hot loops inside functions that were called
with too few arguments.

• dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/microbenchmarks/loop-osr-with-arity-mismatch.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/dfg/DFGOSREntry.cpp (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2019-05-23  Tadeu Zagallo  <tzagallo@apple.com>
+
+        DFG::OSREntry should not perform arity check
+        https://bugs.webkit.org/show_bug.cgi?id=198189
+
+        Reviewed by Saam Barati.
+
+        * microbenchmarks/loop-osr-with-arity-mismatch.js: Added.
+        (foo):
+
 2019-05-23  Stephan Szabo  <stephan.szabo@sony.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-05-23  Tadeu Zagallo  <tzagallo@apple.com>
+
+        DFG::OSREntry should not perform arity check
+        https://bugs.webkit.org/show_bug.cgi?id=198189
+
+        Reviewed by Saam Barati.
+
+        The check prevents OSR entering from hot loops inside functions that were called
+        with too few arguments.
+
+        * dfg/DFGOSREntry.cpp:
+        (JSC::DFG::prepareOSREntry):
+
 2019-05-23  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/Source/JavaScriptCore/dfg/DFGOSREntry.cpp

@@ -178 +178 @@
     
     for (size_t argument = 0; argument < entry->m_expectedValues.numberOfArguments(); ++argument) {
-        if (argument >= exec->argumentCountIncludingThis()) {
-            if (Options::verboseOSR()) {
-                dataLogF("    OSR failed because argument %zu was not passed, expected ", argument);
-                entry->m_expectedValues.argument(argument).dump(WTF::dataFile());
-                dataLogF(".\n");
-            }
-            return nullptr;
-        }
-        
         JSValue value;
         if (!argument)