Changeset 245819 in webkit

Timestamp:

May 28, 2019 12:06:18 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

webkitpy: Using sudo on iOS device during timeout spindumps
​https://bugs.webkit.org/show_bug.cgi?id=198142

Patch by David Xiong <​w_xiong@apple.com> on 2019-05-28
Reviewed by Jonathan Bedard.

• Scripts/webkitpy/port/darwin.py:

(DarwinPort.sample_process): Check target host instead of source host for sudo command.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/darwin.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-05-28  David Xiong  <w_xiong@apple.com>
+
+        webkitpy: Using sudo on iOS device during timeout spindumps 
+        https://bugs.webkit.org/show_bug.cgi?id=198142
+
+        Reviewed by Jonathan Bedard.
+
+        * Scripts/webkitpy/port/darwin.py:
+        (DarwinPort.sample_process): Check target host instead of source host for sudo command.
+
 2019-05-28  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/darwin.py

@@ -169 +169 @@
             DarwinPort.spindump_file_path(host, name, pid, str(tempdir)),
         ]
-        if self.host.platform.is_mac():
+        if host.platform.is_mac():
             command = ['/usr/bin/sudo', '-n'] + command
         exit_status = host.executive.run_command(command, return_exit_code=True)