Changeset 245820 in webkit


Ignore:
Timestamp:
May 28, 2019 12:08:21 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

[Pointer Events WPT] Unflake imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html
​https://bugs.webkit.org/show_bug.cgi?id=197008

Patch by Antoine Quint <Antoine Quint> on 2019-05-28
Reviewed by Jon Lee.

We raised an issue on the WPT test which was testing the event timestamp in an invalid manner (see ​https://github.com/w3c/pointerevents/issues/284
and ​https://github.com/web-platform-tests/wpt/issues/170160). As a result this test now passes reliably, so we can update the expected out and
the TestExpectations.

LayoutTests/imported/w3c:

  • web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt:
  • web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html:

LayoutTests:

  • platform/mac/TestExpectations:
Location:
trunk/LayoutTests
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r245818 r245820  
     12019-05-28  Antoine Quint  <graouts@apple.com>
     2
     3        [Pointer Events WPT] Unflake imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html
     4        https://bugs.webkit.org/show_bug.cgi?id=197008
     5
     6        Reviewed by Jon Lee.
     7
     8        We raised an issue on the WPT test which was testing the event timestamp in an invalid manner (see https://github.com/w3c/pointerevents/issues/284
     9        and https://github.com/web-platform-tests/wpt/issues/170160). As a result this test now passes reliably, so we can update the expected out and
     10        the TestExpectations.
     11
     12        * platform/mac/TestExpectations:
     13
    1142019-05-28  Antti Koivisto  <antti@apple.com>
    215

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r245798 r245820  
     12019-05-28  Antoine Quint  <graouts@apple.com>
     2
     3        [Pointer Events WPT] Unflake imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html
     4        https://bugs.webkit.org/show_bug.cgi?id=197008
     5
     6        Reviewed by Jon Lee.
     7
     8        We raised an issue on the WPT test which was testing the event timestamp in an invalid manner (see https://github.com/w3c/pointerevents/issues/284
     9        and https://github.com/web-platform-tests/wpt/issues/170160). As a result this test now passes reliably, so we can update the expected out and
     10        the TestExpectations.
     11
     12        * web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt:
     13        * web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html:
     14
    1152019-05-27  Oriol Brufau  <obrufau@igalia.com>
    216

  • trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt

    r244393 r245820  
    1111The following pointer types were detected: mouse.
    1212
    13 The following events were logged: mouseup@target0, mousedown@target1, mousemove@target1, mouseup@target1.
     13The following events were logged: mousedown@target1, mousemove@target1, mouseup@target1.
    1414
    15 
    16 Harness Error (FAIL), message = 1 duplicate test name: "mouseup's time stamp should be the same as pointerup's time stamp."
    1715
    1816PASS Suppress compat mouse events on drag
    1917PASS primary pointer pointerdown@target0
    20 PASS mouseup's time stamp should be the same as pointerup's time stamp.
    21 PASS Pointer Event: Suppress compatibility mouse events on drag
    2218PASS primary pointer pointerdown@target1
    23 PASS mousedown's time stamp should be the same as pointerdown's time stamp.
    24 PASS Pointer Event: Suppress compatibility mouse events on drag 1
    25 PASS mousemove's time stamp should be the same as pointermove's time stamp.
    26 FAIL Pointer Event: Suppress compatibility mouse events on drag 2 assert_equals: The time stamp of the compat mouse event should be the same as its pointerevent expected 100 but got 99
    27 PASS mouseup's time stamp should be the same as pointerup's time stamp.
    28 PASS Pointer Event: Suppress compatibility mouse events on drag 3
    29 FAIL Event log assert_equals: expected "mousedown@target1, mousemove@target1, mouseup@target1" but got "mouseup@target0, mousedown@target1, mousemove@target1, mouseup@target1"
     19PASS Event log
    3020

  • trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html

    r244393 r245820  
    4747          var pointer_event_list = ["pointerdown" , "pointermove", "pointerup"];
    4848          var mouse_event_list = ["mousedown", "mouseup", "mousemove"];
    49           var last_pointer_event = null;
    5049
    5150          target_list.forEach(function(targetId) {
    … …  
    6564                      if (label === "pointerdown@target0")
    6665                          event.preventDefault();
    67 
    68                       last_pointer_event = event;
    6966                  });
    7067              });
    … …  
    7875
    7976                      include_next_mousemove = (event.type == "mousedown");
    80                       test(function() {
    81                           test(function () {
    82                               assert_equals(event.timeStamp, last_pointer_event.timeStamp, "The time stamp of the compat mouse event should be the same as its pointerevent");
    83                           });
    84                       }, event.type + "'s time stamp should be the same as " + last_pointer_event.type + "'s time stamp.");
    8577                  });
    8678              });

  • trunk/LayoutTests/platform/mac/TestExpectations

    r245773 r245820  
    18811881
    18821882webkit.org/b/197005 imported/w3c/web-platform-tests/pointerevents/pointerevent_lostpointercapture_is_first.html [ Skip ]
    1883 webkit.org/b/197008 imported/w3c/web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html [ Pass Failure ]
    18841883webkit.org/b/197007 imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_coordinates_when_locked.html [ Skip ]
    18851884webkit.org/b/197009 imported/w3c/web-platform-tests/pointerevents/pointerevent_setpointercapture_invalid_pointerid.html [ Failure Pass ]
Note: See TracChangeset for help on using the changeset viewer.