Changeset 245877 in webkit

Timestamp:

May 29, 2019 4:23:49 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION (r244182) [Mac WK2] Layout Test imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=197286

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2019-05-29
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

This is a time sensitive test. It expects to receive a resize event within
two frames after the page load. Scheduling the page update through the
RenderingUpdate made updating the page for the first time happens not
immediately after the page load but after an additional frame.

So we need to wait for this additional frame before checking whether the
'resize' event was fired.

• web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html:

LayoutTests:

• platform/mac-wk2/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• imported/w3c/ChangeLog (modified) (1 diff)
• imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html (modified) (1 diff)
• platform/mac-wk2/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-05-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        REGRESSION (r244182) [Mac WK2] Layout Test imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=197286
+
+        Reviewed by Simon Fraser.
+
+        * platform/mac-wk2/TestExpectations:
+
 2019-05-29  Youenn Fablet  <youenn@apple.com>
 

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2019-05-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        REGRESSION (r244182) [Mac WK2] Layout Test imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=197286
+
+        Reviewed by Simon Fraser.
+
+        This is a time sensitive test. It expects to receive a resize event within
+        two frames after the page load. Scheduling the page update through the 
+        RenderingUpdate made updating the page for the first time happens not 
+        immediately after the page load but after an additional frame.
+
+        So we need to wait for this additional frame before checking whether the
+        'resize' event was fired.
+
+        * web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html:
+
 2019-05-29  Antoine Quint  <graouts@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html

@@ -27 +27 @@
 
                 window.addEventListener('load', function() {
-                  requestAnimationFrame(function() {
-                    requestAnimationFrame(
-                        t.step_func_done(function() {
+                    var count = 0;
+                    requestAnimationFrame(function step() {
+                        // Wait for two RenderingUpdates before checking the value of numViewResizes.
+                        if (count++ < 2) {
+                            requestAnimationFrame(step);
+                            return;
+                        }
+
+                        requestAnimationFrame(t.step_func_done(function() {
                             var isOverlay = calculateScrollbarThickness() == 0;
                             assert_equals(numViewResizes, isOverlay ? 0 : 1);

trunk/LayoutTests/platform/mac-wk2/TestExpectations

@@ -943 +943 @@
 webkit.org/b/197207 http/wpt/resource-timing/rt-resources-per-frame.html [ Pass Failure ]
 
-webkit.org/b/197286 imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html [ Pass Failure ]
-
 webkit.org/b/197425 [ Mojave Debug ] scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html [ Pass Failure ]