Changeset 246025 in webkit


Ignore:
Timestamp:
Jun 2, 2019 4:34:36 PM (5 years ago)
Author:
Devin Rousso
Message:

Web Inspector: propagate whether to show prototype information to subobject views
​https://bugs.webkit.org/show_bug.cgi?id=194929

Reviewed by Matt Baker.

Add a way to mark the ObjectTreeView as holding a JSON value, which extends
showOnlyProperties to also hide the prototype of all held values (e.g. children).

  • UserInterface/Views/ObjectTreeView.js:

(WI.ObjectTreeView.prototype.showOnlyJSON): Added.

  • UserInterface/Views/ObjectTreeView.css:

(.object-tree.properties-only.json-only .object-tree-property .prototype-property): Added.

  • UserInterface/Views/AuditTestCaseContentView.js:

(WI.AuditTestCaseContentView.prototype.layout):

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WI.DOMNodeDetailsSidebarPanel.prototype._refreshAssociatedData):

  • UserInterface/Views/JSONResourceContentView.css:

(.content-view.resource.json .object-tree .prototype-property): Deleted.

  • UserInterface/Views/JSONResourceContentView.js:

(WI.JSONResourceContentView.prototype.contentAvailable):

Location:
trunk/Source/WebInspectorUI
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebInspectorUI/ChangeLog

    r245991 r246025  
     12019-06-02  Devin Rousso  <drousso@apple.com>
     2
     3        Web Inspector: propagate whether to show prototype information to subobject views
     4        https://bugs.webkit.org/show_bug.cgi?id=194929
     5
     6        Reviewed by Matt Baker.
     7
     8        Add a way to mark the `ObjectTreeView` as holding a JSON value, which extends
     9        `showOnlyProperties` to also hide the prototype of all held values (e.g. children).
     10
     11        * UserInterface/Views/ObjectTreeView.js:
     12        (WI.ObjectTreeView.prototype.showOnlyJSON): Added.
     13        * UserInterface/Views/ObjectTreeView.css:
     14        (.object-tree.properties-only.json-only .object-tree-property .prototype-property): Added.
     15
     16        * UserInterface/Views/AuditTestCaseContentView.js:
     17        (WI.AuditTestCaseContentView.prototype.layout):
     18        * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
     19        (WI.DOMNodeDetailsSidebarPanel.prototype._refreshAssociatedData):
     20        * UserInterface/Views/JSONResourceContentView.css:
     21        (.content-view.resource.json .object-tree .prototype-property): Deleted.
     22        * UserInterface/Views/JSONResourceContentView.js:
     23        (WI.JSONResourceContentView.prototype.contentAvailable):
     24
    1252019-05-31  Nikita Vasilyev  <nvasilyev@apple.com>
    226

  • trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestCaseContentView.js

    r245914 r246025  
    162162                    let objectTree = element.__objectTree;
    163163                    if (objectTree) {
    164                         objectTree.showOnlyProperties();
     164                        objectTree.showOnlyJSON();
    165165                        objectTree.expand();
    166166                    }

  • trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js

    r243244 r246025  
    522522                let objectTree = element.__objectTree;
    523523                if (objectTree) {
    524                     objectTree.showOnlyProperties();
     524                    objectTree.showOnlyJSON();
    525525                    objectTree.expand();
    526526                }

  • trunk/Source/WebInspectorUI/UserInterface/Views/JSONResourceContentView.css

    r223806 r246025  
    2828    overflow: scroll;
    2929}
    30 
    31 .content-view.resource.json .object-tree .prototype-property {
    32     display: none;
    33 }

  • trunk/Source/WebInspectorUI/UserInterface/Views/JSONResourceContentView.js

    r235873 r246025  
    7070
    7171            let objectTree = new WI.ObjectTreeView(this._remoteObject);
     72            objectTree.showOnlyJSON();
    7273            objectTree.expand();
    7374

  • trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.css

    r238711 r246025  
    108108}
    109109
     110.object-tree.properties-only.json-only .object-tree-property .prototype-property {
     111    display: none;
     112}
     113
    110114.tree-outline.object li {
    111115    white-space: nowrap;

  • trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js

    r242386 r246025  
    223223    }
    224224
     225    showOnlyJSON()
     226    {
     227        this.showOnlyProperties();
     228
     229        this._element.classList.add("json-only");
     230    }
     231
    225232    appendTitleSuffix(suffixElement)
    226233    {
Note: See TracChangeset for help on using the changeset viewer.