Changeset 246027 in webkit

Timestamp:

Jun 2, 2019 7:12:59 PM (5 years ago)

Author:

Devin Rousso

Message:

Flaky Test: inspector/canvas/recording.html
​https://bugs.webkit.org/show_bug.cgi?id=198470

Reviewed by Matt Baker.

• inspector/canvas/recording.html:

Don't rely on frameCount to automatically stop the recording, as that's dependent on when
the <canvas> paints and is less controllable/deterministic.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• inspector/canvas/recording.html (modified) (6 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-06-02  Devin Rousso  <drousso@apple.com>
+
+        Flaky Test: inspector/canvas/recording.html
+        https://bugs.webkit.org/show_bug.cgi?id=198470
+
+        Reviewed by Matt Baker.
+
+        * inspector/canvas/recording.html:
+        Don't rely on `frameCount` to automatically stop the recording, as that's dependent on when
+        the <canvas> paints and is less controllable/deterministic.
+
 2019-06-01  Simon Fraser  <simon.fraser@apple.com>
 

trunk/LayoutTests/inspector/canvas/recording.html

@@ -45 +45 @@
             .then((event) => {
                 InspectorTest.evaluateInPage(`performActionsNaN()`);
-            });
 
-            const frameCount = 1;
-            CanvasAgent.startRecording(canvas.identifier, frameCount)
+                canvas.stopRecording();
+            })
             .catch(reject);
+
+            canvas.startRecording();
         },
     });
@@ -57 +58 @@
         description: "Check that multiple recordings are able to be started/stopped at the same time.",
         test(resolve, reject) {
-            const singleFrame = false;
-
             let canvases = WI.canvasManager.canvases;
             InspectorTest.assert(canvases.length === 2, "There should be two canvas contexts.");
@@ -74 +73 @@
                 InspectorTest.log("Stopping the recording of canvas 2...");
                 canvases[1].stopRecording();
-            });
+            })
+            .catch(reject);
 
             InspectorTest.awaitEvent("TestPage-performActionsMultiple")
@@ -82 +82 @@
                 InspectorTest.log("Stopping the recording of canvas 1...");
                 canvases[0].stopRecording();
-            });
+            })
+            .catch(reject);
 
             canvases[1].awaitEvent(WI.Canvas.Event.RecordingStarted)
@@ -90 +91 @@
                 InspectorTest.log("Performing actions...");
                 InspectorTest.evaluateInPage(`performActionsMultiple()`);
-            });
+            })
+            .catch(reject);
 
             canvases[0].awaitEvent(WI.Canvas.Event.RecordingStarted)
@@ -97 +99 @@
 
                 InspectorTest.log("Starting a recording of canvas 2...");
-                canvases[1].startRecording(singleFrame);
-            });
+                canvases[1].startRecording();
+            })
+            .catch(reject);
 
             InspectorTest.log("Starting a recording of canvas 1...");
-            canvases[0].startRecording(singleFrame);
+            canvases[0].startRecording();
         },
     });