Changeset 246069 in webkit

Timestamp:

Jun 4, 2019 10:09:04 AM (5 years ago)

Author:

Chris Dumez

Message:

Lazily construct the NetworkHTTPSUpgradeChecker
​https://bugs.webkit.org/show_bug.cgi?id=198500

Reviewed by Alex Christensen.

Lazily construct the NetworkHTTPSUpgradeChecker since the feature is off by default and this
avoids unnecessarily opening its database in the common case.

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::networkHTTPSUpgradeChecker):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/NetworkProcess.h (modified) (2 diffs)
• NetworkProcess/cocoa/NetworkProcessCocoa.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-06-04  Chris Dumez  <cdumez@apple.com>
+
+        Lazily construct the NetworkHTTPSUpgradeChecker
+        https://bugs.webkit.org/show_bug.cgi?id=198500
+
+        Reviewed by Alex Christensen.
+
+        Lazily construct the NetworkHTTPSUpgradeChecker since the feature is off by default and this
+        avoids unnecessarily opening its database in the common case.
+
+        * NetworkProcess/NetworkProcess.h:
+        * NetworkProcess/cocoa/NetworkProcessCocoa.mm:
+        (WebKit::NetworkProcess::networkHTTPSUpgradeChecker):
+
 2019-06-04  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/NetworkProcess/NetworkProcess.h

@@ -317 +317 @@
 
 #if PLATFORM(COCOA)
-    NetworkHTTPSUpgradeChecker& networkHTTPSUpgradeChecker() { return m_networkHTTPSUpgradeChecker; }
+    NetworkHTTPSUpgradeChecker& networkHTTPSUpgradeChecker();
 #endif
 
@@ -547 +547 @@
 
 #if PLATFORM(COCOA)
-    NetworkHTTPSUpgradeChecker m_networkHTTPSUpgradeChecker;
+    std::unique_ptr<NetworkHTTPSUpgradeChecker> m_networkHTTPSUpgradeChecker;
 #endif
 

trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm

@@ -305 +305 @@
 }
 
+NetworkHTTPSUpgradeChecker& NetworkProcess::networkHTTPSUpgradeChecker()
+{
+    if (!m_networkHTTPSUpgradeChecker)
+        m_networkHTTPSUpgradeChecker = std::make_unique<NetworkHTTPSUpgradeChecker>();
+    return *m_networkHTTPSUpgradeChecker;
+}
+
 } // namespace WebKit