Changeset 246099 in webkit

Timestamp:

Jun 4, 2019 11:09:24 PM (5 years ago)

Author:

rniwa@webkit.org

Message:

iPadOS: Google calendars new event picker moves and flickers in landscape with software keyboard
​https://bugs.webkit.org/show_bug.cgi?id=198556

Reviewed by Wenson Hsieh.

Fix the issuse that it's really hard to create a new event using Google calendar on iPadOS with
a software keyboard enabled because tapping on date brings up software keyboard and erratically
shifts up/down the new event dialog/pane.

Add a site specific quirk to pretend these input elements have inputmode=none for now.

No new tests since this is a site specific quirk.

• page/Quirks.cpp:

(WebCore::Quirks::needsInputModeNoneImplicitly const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Quirks.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-04  Ryosuke Niwa  <rniwa@webkit.org>
+
+        iPadOS: Google calendars new event picker moves and flickers in landscape with software keyboard
+        https://bugs.webkit.org/show_bug.cgi?id=198556
+
+        Reviewed by Wenson Hsieh.
+
+        Fix the issuse that it's really hard to create a new event using Google calendar on iPadOS with
+        a software keyboard enabled because tapping on date brings up software keyboard and erratically
+        shifts up/down the new event dialog/pane.
+
+        Add a site specific quirk to pretend these input elements have inputmode=none for now.
+
+        No new tests since this is a site specific quirk.
+
+        * page/Quirks.cpp:
+        (WebCore::Quirks::needsInputModeNoneImplicitly const):
+
 2019-06-04  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/page/Quirks.cpp

@@ -339 +339 @@
         return false;
 
+    if (element.hasTagName(HTMLNames::inputTag)) {
+        if (!equalLettersIgnoringASCIICase(m_document->url().host(), "calendar.google.com"))
+            return false;
+        static NeverDestroyed<QualifiedName> dataInitialValueAttr(nullAtom(), "data-initial-value", nullAtom());
+        static NeverDestroyed<QualifiedName> dataPreviousValueAttr(nullAtom(), "data-previous-value", nullAtom());
+
+        return equalLettersIgnoringASCIICase(element.attributeWithoutSynchronization(HTMLNames::autocompleteAttr), "off")
+            && element.hasAttributeWithoutSynchronization(dataInitialValueAttr)
+            && element.hasAttributeWithoutSynchronization(dataPreviousValueAttr);
+    }
+
     if (!element.hasTagName(HTMLNames::textareaTag))
         return false;