Changeset 246165 in webkit
- Timestamp:
- Jun 6, 2019 12:32:51 PM (5 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r246162 r246165 1 2019-06-06 Antoine Quint <graouts@apple.com> 2 3 Restrict fast clicks everywhere to desktop content mode 4 https://bugs.webkit.org/show_bug.cgi?id=198610 5 <rdar://problem/50114230> 6 7 Reviewed by Dean Jackson. 8 9 Add a new test that enables fast clicks but also sets a mobile content mode. 10 11 * fast/events/ios/ipad/fast-click-always-mobile-content-mode-expected.txt: Added. 12 * fast/events/ios/ipad/fast-click-always-mobile-content-mode.html: Added. 13 1 14 2019-06-06 Alexey Shvayka <shvaikalesh@gmail.com> 2 15 -
trunk/Source/WebKit/ChangeLog
r246163 r246165 1 2019-06-06 Antoine Quint <graouts@apple.com> 2 3 Restrict fast clicks everywhere to desktop content mode 4 https://bugs.webkit.org/show_bug.cgi?id=198610 5 <rdar://problem/50114230> 6 7 Reviewed by Dean Jackson. 8 9 * UIProcess/WebPageProxy.h: 10 (WebKit::WebPageProxy::allowsFastClicksEverywhere const): 11 * UIProcess/ios/WKContentViewInteraction.mm: 12 (-[WKContentView _handleSmartMagnificationInformationForPotentialTap:renderRect:fitEntireRect:viewportMinimumScale:viewportMaximumScale:]): 13 * UIProcess/ios/WebPageProxyIOS.mm: 14 (WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies): 15 1 16 2019-06-06 Sihui Liu <sihui_liu@apple.com> 2 17 -
trunk/Source/WebKit/UIProcess/WebPageProxy.h
r246136 r246165 519 519 bool hasCommittedAnyProvisionalLoads() const { return m_hasCommittedAnyProvisionalLoads; } 520 520 521 bool allowsFastClicksEverywhere() const { return m_allowsFastClicksEverywhere; } 522 521 523 void setIsUsingHighPerformanceWebGL(bool value) { m_isUsingHighPerformanceWebGL = value; } 522 524 bool isUsingHighPerformanceWebGL() const { return m_isUsingHighPerformanceWebGL; } … … 2479 2481 bool m_openedByDOM { false }; 2480 2482 bool m_hasCommittedAnyProvisionalLoads { false }; 2483 bool m_allowsFastClicksEverywhere { false }; 2481 2484 2482 2485 HashMap<String, Ref<WebURLSchemeHandler>> m_urlSchemeHandlersByScheme; -
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
r246157 r246165 1588 1588 return; 1589 1589 1590 if (_page->preferences().fastClicksEverywhere() ) {1590 if (_page->preferences().fastClicksEverywhere() && _page->allowsFastClicksEverywhere()) { 1591 1591 RELEASE_LOG(ViewGestures, "Potential tap found an element and fast taps are forced on. Trigger click. (%p)", self); 1592 1592 [self _setDoubleTapGesturesEnabled:NO]; -
trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
r246118 r246165 1377 1377 } 1378 1378 1379 m_allowsFastClicksEverywhere = false; 1380 1379 1381 if (!useDesktopBrowsingMode) 1380 1382 return WebContentMode::Mobile; … … 1398 1400 policies.setSimulatedMouseEventsDispatchPolicy(WebsiteSimulatedMouseEventsDispatchPolicy::Allow); 1399 1401 policies.setLegacyOverflowScrollingTouchPolicy(WebsiteLegacyOverflowScrollingTouchPolicy::Disable); 1402 m_allowsFastClicksEverywhere = true; 1400 1403 } 1401 1404
Note: See TracChangeset
for help on using the changeset viewer.