Changeset 246165 in webkit


Ignore:
Timestamp:
Jun 6, 2019 12:32:51 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Restrict fast clicks everywhere to desktop content mode
​https://bugs.webkit.org/show_bug.cgi?id=198610
<rdar://problem/50114230>

Patch by Antoine Quint <Antoine Quint> on 2019-06-06
Reviewed by Dean Jackson.

Source/WebKit:

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::allowsFastClicksEverywhere const):

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _handleSmartMagnificationInformationForPotentialTap:renderRect:fitEntireRect:viewportMinimumScale:viewportMaximumScale:]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies):

LayoutTests:

Add a new test that enables fast clicks but also sets a mobile content mode.

  • fast/events/ios/ipad/fast-click-always-mobile-content-mode-expected.txt: Added.
  • fast/events/ios/ipad/fast-click-always-mobile-content-mode.html: Added.
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r246162 r246165  
     12019-06-06  Antoine Quint  <graouts@apple.com>
     2
     3        Restrict fast clicks everywhere to desktop content mode
     4        https://bugs.webkit.org/show_bug.cgi?id=198610
     5        <rdar://problem/50114230>
     6
     7        Reviewed by Dean Jackson.
     8
     9        Add a new test that enables fast clicks but also sets a mobile content mode.
     10
     11        * fast/events/ios/ipad/fast-click-always-mobile-content-mode-expected.txt: Added.
     12        * fast/events/ios/ipad/fast-click-always-mobile-content-mode.html: Added.
     13
    1142019-06-06  Alexey Shvayka  <shvaikalesh@gmail.com>
    215

  • trunk/Source/WebKit/ChangeLog

    r246163 r246165  
     12019-06-06  Antoine Quint  <graouts@apple.com>
     2
     3        Restrict fast clicks everywhere to desktop content mode
     4        https://bugs.webkit.org/show_bug.cgi?id=198610
     5        <rdar://problem/50114230>
     6
     7        Reviewed by Dean Jackson.
     8
     9        * UIProcess/WebPageProxy.h:
     10        (WebKit::WebPageProxy::allowsFastClicksEverywhere const):
     11        * UIProcess/ios/WKContentViewInteraction.mm:
     12        (-[WKContentView _handleSmartMagnificationInformationForPotentialTap:renderRect:fitEntireRect:viewportMinimumScale:viewportMaximumScale:]):
     13        * UIProcess/ios/WebPageProxyIOS.mm:
     14        (WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies):
     15
    1162019-06-06  Sihui Liu  <sihui_liu@apple.com>
    217

  • trunk/Source/WebKit/UIProcess/WebPageProxy.h

    r246136 r246165  
    519519    bool hasCommittedAnyProvisionalLoads() const { return m_hasCommittedAnyProvisionalLoads; }
    520520
     521    bool allowsFastClicksEverywhere() const { return m_allowsFastClicksEverywhere; }
     522
    521523    void setIsUsingHighPerformanceWebGL(bool value) { m_isUsingHighPerformanceWebGL = value; }
    522524    bool isUsingHighPerformanceWebGL() const { return m_isUsingHighPerformanceWebGL; }
    … …  
    24792481    bool m_openedByDOM { false };
    24802482    bool m_hasCommittedAnyProvisionalLoads { false };
     2483    bool m_allowsFastClicksEverywhere { false };
    24812484
    24822485    HashMap<String, Ref<WebURLSchemeHandler>> m_urlSchemeHandlersByScheme;

  • trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

    r246157 r246165  
    15881588        return;
    15891589
    1590     if (_page->preferences().fastClicksEverywhere()) {
     1590    if (_page->preferences().fastClicksEverywhere() && _page->allowsFastClicksEverywhere()) {
    15911591        RELEASE_LOG(ViewGestures, "Potential tap found an element and fast taps are forced on. Trigger click. (%p)", self);
    15921592        [self _setDoubleTapGesturesEnabled:NO];

  • trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm

    r246118 r246165  
    13771377    }
    13781378
     1379    m_allowsFastClicksEverywhere = false;
     1380
    13791381    if (!useDesktopBrowsingMode)
    13801382        return WebContentMode::Mobile;
    … …  
    13981400        policies.setSimulatedMouseEventsDispatchPolicy(WebsiteSimulatedMouseEventsDispatchPolicy::Allow);
    13991401        policies.setLegacyOverflowScrollingTouchPolicy(WebsiteLegacyOverflowScrollingTouchPolicy::Disable);
     1402        m_allowsFastClicksEverywhere = true;
    14001403    }
    14011404
Note: See TracChangeset for help on using the changeset viewer.